Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] [ADD] account_invoice_restrict_linked_so: New module to restrict invoice lines created from SO. #1004

Merged
merged 1 commit into from
Sep 23, 2021
Merged

[14.0] [ADD] account_invoice_restrict_linked_so: New module to restrict invoice lines created from SO. #1004

merged 1 commit into from
Sep 23, 2021

Conversation

Chandresh-OSI
Copy link
Contributor

No description provided.

@Chandresh-OSI Chandresh-OSI force-pushed the 14.0_ADD_account_invoice_restrict_linked_so branch from 5813784 to e5e3e1a Compare September 20, 2021 19:43
dreispt
dreispt reviewed Sep 20, 2021
View reviewed changes
Copy link
Member

@dreispt dreispt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review looks good. Will do some tests.

dreispt
dreispt approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@dreispt dreispt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works as expected.

patrickrwilson
patrickrwilson approved these changes Sep 21, 2021
View reviewed changes
Copy link

@patrickrwilson patrickrwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bodedra
bodedra approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@bodedra bodedra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional reviewed. 👍

Tried with normal sale invoice and down payment. Works great!

Added suggestion to add account module in a dependency.

account_invoice_restrict_linked_so/__manifest__.py Show resolved Hide resolved
@dreispt
Copy link
Member

dreispt commented Sep 23, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1004-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6b0a033 into OCA:14.0 Sep 23, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 37993df. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreispt dreispt dreispt approved these changes

@bodedra bodedra bodedra approved these changes

@patrickrwilson patrickrwilson patrickrwilson approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Chandresh-OSI @dreispt @OCA-git-bot @bodedra @patrickrwilson