Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] [16.0] account_invoice_report_grouped_by_picking: next_line empty to avoid dict.get #320

Conversation

Shide
Copy link
Contributor

@Shide Shide commented May 16, 2024

next_line is empty to avoid dict.get and throw an AttributeError

MT-6181 @moduon @EmilioPascual @rafaelbn @fcvalgar @Gelojr please review if you want :)

@rafaelbn rafaelbn added this to the 16.0 milestone May 17, 2024
@rafaelbn rafaelbn requested a review from manuelregidor May 17, 2024 17:25
@rafaelbn
Copy link
Member

@Shide is this FIX similar to #318 ?

Ping @ferran-S73 😄 ❤️

@pedrobaeza
Copy link
Member

Yes, this seems to fix the same thing as #318. Please avoid all the noise of adding the contributor for a quick merge.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-320-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 099e3af into OCA:16.0 May 23, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7b43019. Thanks a lot for contributing to OCA. ❤️

@Shide Shide deleted the 16.0-fix_report_print_error-account_invoice_report_grouped_by_picking branch May 24, 2024 07:39
BT-etejeda pushed a commit to BT-etejeda/account-invoice-reporting that referenced this pull request Feb 6, 2025
Syncing from upstream OCA/account-invoice-reporting (17.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants