Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] account_invoice_report_grouped_by_picking: Show lines/section in manually created invoice lines #311

Merged
merged 2 commits into from
May 2, 2024
Merged

[16.0][FIX] account_invoice_report_grouped_by_picking: Show lines/section in manually created invoice lines #311

merged 2 commits into from
May 2, 2024

Conversation

manuelregidor
Copy link
Contributor

@manuelregidor manuelregidor commented Apr 15, 2024 •
edited
Loading

Based on #308

T-5953

@manuelregidor
Copy link
Contributor Author

@Jesarregui @HaraldPanten @ValentinVinagre

ValentinVinagre
ValentinVinagre approved these changes Apr 22, 2024
View reviewed changes
Copy link

@ValentinVinagre ValentinVinagre left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@HaraldPanten
Copy link

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-311-by-HaraldPanten-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 29, 2024
@OCA-git-bot
Merge PR #311 into 16.0
cafe04a 
Signed-off-by HaraldPanten
@HaraldPanten HaraldPanten changed the title [WIP][16.0][FIX] account_invoice_report_grouped_by_picking: Show lines/section in manually created invoice lines [16.0][FIX] account_invoice_report_grouped_by_picking: Show lines/section in manually created invoice lines Apr 29, 2024
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

@HaraldPanten your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-311-by-HaraldPanten-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@manuelregidor manuelregidor force-pushed the 16.0-fix-account_invoice_report_grouped_by_picking branch from 0426a0f to c3a2fdf Compare May 2, 2024 14:21
@HaraldPanten
Copy link

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-311-by-HaraldPanten-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 525f98d into OCA:16.0 May 2, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 88145d7. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 16.0-fix-account_invoice_report_grouped_by_picking branch May 2, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaraldPanten HaraldPanten HaraldPanten approved these changes

@ValentinVinagre ValentinVinagre ValentinVinagre approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manuelregidor @HaraldPanten @OCA-git-bot @ValentinVinagre