Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] account_comment_template: allow to use dynamic information in template #286

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

alan196
Copy link
Contributor

@alan196 alan196 commented Aug 21, 2023

With this change it allows to generate templates with dynamic content

@pedrobaeza pedrobaeza added this to the 16.0 milestone Aug 22, 2023
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • t-raw is deprecated. Use t-out. Anyway, that's not for dynamic expressions, but for HTML.
  • This is not [ADD], but [IMP].

@alan196 alan196 changed the title [16.0][ADD] account_comment_template: allow to use dynamic information in template [16.0][IMP] account_comment_template: allow to use dynamic information in template Aug 22, 2023
@alan196 alan196 force-pushed the 16.0-fix-account_comment_template branch from 4267080 to 01e28e9 Compare August 22, 2023 14:17
@alan196
Copy link
Contributor Author

alan196 commented Aug 22, 2023

@pedrobaeza thanks for the review! I updated the requested changes 👍

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-286-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0a6f1b7 into OCA:16.0 Sep 11, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8eff072. Thanks a lot for contributing to OCA. ❤️

@alan196 alan196 deleted the 16.0-fix-account_comment_template branch September 11, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants