Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0] [MIG] account_product_fiscal_classification #417

Closed

Conversation

Nikul-OSI
Copy link

odoo/odoo#110016

@rvalyi @ovnicraft @azmeuk Can you please check this PR?

rvalyi and others added 30 commits March 12, 2024 10:02
…ng with product taxes from an other (sub) company
… added company_id.id parameter in search method in account.tax objects
…t_product_fiscal_classification and account_fiscal_position_rule and remove old files __terp__.py
…toring and changed in account_product_fiscal_classification module product.product to product.template
…ification changed header files and included in __openerp__.py explicit AGPL-3 license
…methods in in object account.product.fiscal.classification
…lled at the installation, and no during update anymore;
weblate and others added 11 commits March 12, 2024 10:02
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-fiscal-rule-16.0/account-fiscal-rule-16.0-account_product_fiscal_classification
Translate-URL: https://translation.odoo-community.org/projects/account-fiscal-rule-16-0/account-fiscal-rule-16-0-account_product_fiscal_classification/
Currently translated at 100.0% (55 of 55 strings)

Translation: account-fiscal-rule-16.0/account-fiscal-rule-16.0-account_product_fiscal_classification
Translate-URL: https://translation.odoo-community.org/projects/account-fiscal-rule-16-0/account-fiscal-rule-16-0-account_product_fiscal_classification/es/
Currently translated at 100.0% (55 of 55 strings)

Translation: account-fiscal-rule-16.0/account-fiscal-rule-16.0-account_product_fiscal_classification
Translate-URL: https://translation.odoo-community.org/projects/account-fiscal-rule-16-0/account-fiscal-rule-16-0-account_product_fiscal_classification/fr/
Currently translated at 100.0% (55 of 55 strings)

Translation: account-fiscal-rule-16.0/account-fiscal-rule-16.0-account_product_fiscal_classification
Translate-URL: https://translation.odoo-community.org/projects/account-fiscal-rule-16-0/account-fiscal-rule-16-0-account_product_fiscal_classification/sv/
@Nikul-OSI Nikul-OSI force-pushed the 17_nc_mig_account_product_fiscal_classification branch 3 times, most recently from c817e2b to a23fef7 Compare March 12, 2024 10:50
@Nikul-OSI Nikul-OSI force-pushed the 17_nc_mig_account_product_fiscal_classification branch from a23fef7 to 3eb6e44 Compare March 12, 2024 10:52
@Nikul-OSI
Copy link
Author

@dreispt Can you please take a look and if needed then please change the code?

@Nikul-OSI Nikul-OSI mentioned this pull request Mar 13, 2024
10 tasks
Copy link
Member

@dreispt dreispt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nikul-OSI Added some comments for you to review. Thanks

# self.user_demo,
# self.category_wine,
# self.fiscal_classification_B_company_1,
# )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a WIP?

def create_fiscal_classification_from_product_template(cr, registry):
env = api.Environment(cr, SUPERUSER_ID, {})
def create_fiscal_classification_from_product_template(env):
# env = api.Environment(cr, SUPERUSER_ID, {})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete?

<record id="account_tax_template_sale" model="account.tax.template">
<field name="chart_template_id" ref="chart_template" />
<record id="account_tax_template_sale" model="account.tax">
<!-- <field name="chart_template_id" ref="chart_template" /> -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deletes? Are you sure this is not needed?

Comment on lines +30 to +40

self.account_tax_purchase_20_company_1 = self.AccountTax.create(
{
"name": "TEST Demo Purchase Tax 20% (Your Company)",
"company_id": self.main_company.id,
"type_tax_use": "purchase",
"amount": 20.0,
"tax_group_id": self.env["account.tax.group"]
.create({"name": "Test Taxes"})
.id,
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you recreate demo data ?

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 21, 2024
@gurneyalex
Copy link
Member

/ocabot migration account_product_fiscal_classification

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jul 25, 2024
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 28, 2024
Copy link

github-actions bot commented Dec 1, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 1, 2024
@github-actions github-actions bot closed this Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.