[16.0][IMP] account-financial-tools: ADD account_loan_analytic_account #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmarion-source
force-pushed
the
16.0-analytic_account_account_loan
branch
3 times, most recently
from
fc2067c to
a9e1122
Compare
lmarion-source
changed the title
lmarion-source
force-pushed
the
16.0-analytic_account_account_loan
branch
3 times, most recently
from
6950936 to
6face17
Compare
acsonefho
reviewed
Sep 6, 2024
| and loan | ||
| and vals["account_id"] == loan.interest_expenses_account_id.id | ||
| ): | ||
| vals["analytic_distribution"] = loan.analytic_distribution |
There was a problem hiding this comment.
And what if the user already define some analytic_distribution? You completely overwrite filled values.
There was a problem hiding this comment.
The analytic_distribution on the move_line must follow the one on the loan : if the distribution changes on the loan, the distribution should be erased on the move_line
| and loan | ||
| and vals["account_id"] == loan.interest_expenses_account_id.id | ||
| ): | ||
| vals["analytic_distribution"] = loan.analytic_distribution |
There was a problem hiding this comment.
same here than for the create, the user should not be able to change the distribution on the move_line independently of the loan
lmarion-source
force-pushed
the
16.0-analytic_account_account_loan
branch
from
6face17 to
50232bf
Compare
This module allows to add analytic distributions on loans and propagate them
to moves when the loan is posted
lmarion-source
force-pushed
the
16.0-analytic_account_account_loan
branch
from
50232bf to
daa9e53
Compare
acsonefho
approved these changes
Oct 8, 2024
|
This PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module allows to add analytic distributions on loans and propagate them to moves when the loan is posted