[14.0] [FIX] account_fiscal_year_closing - create/write #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bug also on v16.0 #248 |
When creating from scratch, Mapping is used as an Array instead of simple id (due to many in another many). When coming from a template, id is used To take into account this particularity, check the type before taking the id of the array.
|
I confirm the bug and fix. Please merge this. |
Borruso
suggested changes
May 10, 2024
| @@ -553,13 +553,13 @@ class AccountFiscalyearClosingMapping(models.Model): | |||
|
|
|||
| @api.model | |||
| def create(self, vals): | |||
| if "dest_account_id" in vals: | |||
| if "dest_account_id" in vals and type(vals["dest_account_id"]) == list: | |||
There was a problem hiding this comment.
use isinstance(vals["dest_account_id"], list)
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
Would you please merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating new fiscal year closing with an account mapping (with destination account) in moves configuration, an issue is raised at save (Issue #280).
But when coming from a template (selecting template on screen), Mapping data are used as an Array instead instead of simple id (due to many inside another many).
The current code manage only case from template.
This PR take into account this particularity (and mangage other way), check the type before taking the id of the array.