-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] account_analytic_parent: Migration to 16.0 #501
[16.0][MIG] account_analytic_parent: Migration to 16.0 #501
Conversation
f6a9fce
to
fecb221
Compare
Functional question: now that you can link an analytic plan to analytic accounts in Odoo 16, and analytic plans have a hierarchical parent structure, do we still need this module? @mylbco |
/ocabot migration account_analytic_parent |
.pre-commit-config.yaml
Outdated
@@ -113,7 +113,7 @@ repos: | |||
- requirements.txt | |||
- --header | |||
- "# generated from manifests external_dependencies" | |||
- repo: https://gitlab.com/PyCQA/flake8 | |||
- repo: https://github.com/PyCQA/flake8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed properly in #502. Please rebase.
6a64c42
to
110323e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Code reviewed + tested.
/ocabot migration account_analytic_parent |
/ocabot rebase |
Congratulations, PR rebased to 16.0. |
Strange to find runboat not working. My screenshots were all from runboat. |
Hello @sbidoul , please do you know hoy to detect the reason of this runboat not working? Thank you! 🙏 ❤️ |
Hm. Expired microk8s API certificate. Weird. I'm AFK for a little while but found a temporary workaround, hopefully. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Currently translated at 100.0% (11 of 11 strings) Translation: account-analytic-13.0/account-analytic-13.0-account_analytic_parent Translate-URL: https://translation.odoo-community.org/projects/account-analytic-13-0/account-analytic-13-0-account_analytic_parent/gl/
This is to resolve conflict with `account_analytic_sequence` module.
Currently translated at 100.0% (11 of 11 strings) Translation: account-analytic-15.0/account-analytic-15.0-account_analytic_parent Translate-URL: https://translation.odoo-community.org/projects/account-analytic-15-0/account-analytic-15-0-account_analytic_parent/fr/
Congratulations, PR rebased to 16.0. |
110323e
to
1911139
Compare
@rafaelbn ready to test 👍 |
@StefanRijnhart would you like to finish your review? 😄 |
It seems the issue from #501 (comment) has been resolved! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 053fe0e. Thanks a lot for contributing to OCA. ❤️ |
No description provided.