Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] account_analytic_parent: Migration to 16.0 #501

Merged
merged 64 commits into from
Jan 12, 2024

Conversation

mohammadazeem786
Copy link

No description provided.

@mohammadazeem786 mohammadazeem786 force-pushed the 16.0-mig-account_analytic_parent branch from f6a9fce to fecb221 Compare November 29, 2022 12:11
@mohammadazeem786 mohammadazeem786 mentioned this pull request Nov 29, 2022
18 tasks
@StefanRijnhart
Copy link
Member

Please amend your pre-commit commit. The module name is missing in its description:
image

@StefanRijnhart
Copy link
Member

Functional question: now that you can link an analytic plan to analytic accounts in Odoo 16, and analytic plans have a hierarchical parent structure, do we still need this module? @mylbco

image

@StefanRijnhart
Copy link
Member

/ocabot migration account_analytic_parent

@StefanRijnhart
Copy link
Member

StefanRijnhart commented Nov 30, 2022

To answer my own question, adding plans adds an entry to the analytic distribution widget which is not what we want for the analytic parent structure, so this module is not made obsolete by the introduction of analytic plans in Odoo 16 (IMHO).
image

@@ -113,7 +113,7 @@ repos:
- requirements.txt
- --header
- "# generated from manifests external_dependencies"
- repo: https://gitlab.com/PyCQA/flake8
- repo: https://github.com/PyCQA/flake8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed properly in #502. Please rebase.

@rven rven force-pushed the 16.0-mig-account_analytic_parent branch 2 times, most recently from 6a64c42 to 110323e Compare December 1, 2022 09:16
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Code reviewed + tested.

@StefanRijnhart StefanRijnhart self-requested a review December 2, 2022 08:51
@StefanRijnhart
Copy link
Member

Oh, one more thing: the parents are not visible in the new analytic distribution widget, which makes it impossible to know which is which. Can you check this?
image

@rafaelbn rafaelbn added this to the 16.0 milestone Dec 3, 2022
@rafaelbn
Copy link
Member

rafaelbn commented Dec 3, 2022

/ocabot migration account_analytic_parent

@rafaelbn
Copy link
Member

rafaelbn commented Dec 3, 2022

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 16.0.

@rafaelbn
Copy link
Member

rafaelbn commented Dec 3, 2022

I cannot test runboat

imagen

@rafaelbn rafaelbn closed this Dec 3, 2022
@rafaelbn rafaelbn reopened this Dec 3, 2022
@StefanRijnhart
Copy link
Member

Strange to find runboat not working. My screenshots were all from runboat.

@rafaelbn
Copy link
Member

rafaelbn commented Dec 4, 2022

Hello @sbidoul , please do you know hoy to detect the reason of this runboat not working? Thank you! 🙏 ❤️

@sbidoul
Copy link
Member

sbidoul commented Dec 4, 2022

Hm. Expired microk8s API certificate. Weird. I'm AFK for a little while but found a temporary workaround, hopefully.

@github-actions
Copy link

github-actions bot commented Apr 9, 2023

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 9, 2023
@AaronHForgeFlow AaronHForgeFlow removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 10, 2023
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 13, 2023
@pedrobaeza pedrobaeza changed the title [MIG] account_analytic_parent: Migration to 16.0 [16.0+[MIG] account_analytic_parent: Migration to 16.0 Aug 14, 2023
@pedrobaeza pedrobaeza changed the title [16.0+[MIG] account_analytic_parent: Migration to 16.0 [16.0][MIG] account_analytic_parent: Migration to 16.0 Aug 14, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 16.0.

@OCA-git-bot OCA-git-bot force-pushed the 16.0-mig-account_analytic_parent branch from 110323e to 1911139 Compare December 18, 2023 12:17
@HaraldPanten
Copy link

@rafaelbn ready to test 👍

@rafaelbn
Copy link
Member

@StefanRijnhart would you like to finish your review? 😄

@StefanRijnhart
Copy link
Member

It seems the issue from #501 (comment) has been resolved!

image

Copy link

@robinkeunen robinkeunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@StefanRijnhart
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-501-by-StefanRijnhart-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 37287b7 into OCA:16.0 Jan 12, 2024
8 of 11 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 053fe0e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.