[17.0][OU-ADD] hr_holidays: Migration to 17.0

[remi-filament]

No description provided.

[legalsylvain]

/ocabot migration hr_holidays

[Murtaza-SerpentCS]

Remove unused code.

[remi-filament]

Here, I think it is better to keep these so that we see what we should not update.

[Murtaza-SerpentCS]

I don't think it's useful.

[remi-filament]

IMO it is, and it actually what is usually done on other scripts as well, see for instannce :

OpenUpgrade/openupgrade_scripts/scripts/account/16.0.1.2/noupdate_changes.xml

Lines 9 to 30 in c31d4d6

	<!-- Don't recreate this, as they are usually touched by users and in fact the changes are only to use Command syntax
	<record id="account_payment_term_15days" model="account.payment.term">
	<field name="line_ids" eval="[Command.clear(), Command.create({'value': 'balance', 'value_amount': 0.0, 'days': 15})]"/>
	</record>
	<record id="account_payment_term_21days" model="account.payment.term">
	<field name="line_ids" eval="[Command.clear(), Command.create({'value': 'balance', 'value_amount': 0.0, 'days': 21})]"/>
	</record>
	<record id="account_payment_term_2months" model="account.payment.term">
	<field name="line_ids" eval="[Command.clear(), Command.create({'value': 'balance', 'value_amount': 0.0, 'months': 2})]"/>
	</record>
	<record id="account_payment_term_30days" model="account.payment.term">
	<field name="line_ids" eval="[Command.clear(), Command.create({'value': 'balance', 'value_amount': 0.0, 'days': 30})]"/>
	</record>
	<record id="account_payment_term_45days" model="account.payment.term">
	<field name="line_ids" eval="[Command.clear(), Command.create({'value': 'balance', 'value_amount': 0.0, 'days': 45})]"/>
	</record>
	<record id="account_payment_term_advance_60days" model="account.payment.term">
	<field name="line_ids" eval="[ Command.clear(), Command.create({'value': 'percent', 'value_amount': 30.0, 'days': 0}), Command.create({'value': 'balance', 'value_amount': 0.0, 'days': 60})]"/>
	</record>
	<record id="account_payment_term_immediate" model="account.payment.term">
	<field name="line_ids" eval="[Command.clear(), Command.create({'value': 'balance', 'value_amount': 0.0})]"/>
	</record> -->

The use case where it is useful is for when we run analysis again, (like it was done with #4697) by keeping the comments, we know that these data were commented out willingly, and it was not new data which was added after last analysis or data which was forgotten.

[remi-filament]

Done as per your comments, thanks for your review @Murtaza-SerpentCS