Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][OU-ADD] iap: Nothing to do #4586

Closed
wants to merge 1 commit into from
Closed

[17.0][OU-ADD] iap: Nothing to do #4586

wants to merge 1 commit into from

Conversation

acpMicrocom
Copy link
Contributor

No description provided.

rvalyi
rvalyi approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me. I would say, please just squash the 3 commits in 1.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@legalsylvain
Copy link
Contributor

legalsylvain commented Oct 24, 2024 •
edited
Loading

/ocabot migration iap

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Oct 24, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 24, 2024
Open
@legalsylvain legalsylvain mentioned this pull request Oct 24, 2024
Merged
legalsylvain
legalsylvain requested changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Except state of module

docsource/modules160-170.rst
@@ -204,7 +204,7 @@ Module coverage 16.0 -> 17.0
+---------------------------------------------------+----------------------+-------------------------------------------------+
| http_routing | | |
+---------------------------------------------------+----------------------+-------------------------------------------------+
| iap | | |
| iap | Done | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| iap | Done | |
| iap | Nothing to do | |

@legalsylvain legalsylvain mentioned this pull request Dec 5, 2024
Merged
@remi-filament
Copy link
Contributor

Hi @legalsylvain thanks for taking over this PR can you please close this PR and update migration issue with #4689 merged ?

@hbrunn hbrunn closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legalsylvain legalsylvain legalsylvain requested changes

@xtanuiha xtanuiha xtanuiha approved these changes

@rvalyi rvalyi rvalyi approved these changes

Assignees
No one assigned
Labels
Dependency OK
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
7 participants
@acpMicrocom @OCA-git-bot @legalsylvain @remi-filament @rvalyi @xtanuiha @hbrunn