Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][OU-ADD] account: migration to 17.0 #4488

Closed
wants to merge 2 commits into from

Conversation

flachica
Copy link

I make a PR in order to add a fix in account migrating module

Open this PR in order to facilitate the work of others colaborators that need the account module be migrated

@legalsylvain
Copy link
Contributor

/ocabot migration account

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jun 26, 2024
@OCA-git-bot
Copy link
Contributor

The migration issue (#4124) has not been updated to reference the current pull request because a previous pull request (#4457) is not closed.
Perhaps you should check that there is no duplicate work.
CC @duong77476-viindoo

@ndd-odoo
Copy link
Contributor

Thanks but why dont u suggest change, i'll fix :v

@pedrobaeza
Copy link
Member

Yes, let's honor the first proposal.

@pedrobaeza pedrobaeza closed this Jun 27, 2024
@flachica
Copy link
Author

Yes, let's honor the first proposal.

In the description of the PR I already warned that I had made a PR suggestion to the original repository and that the reason for opening this one was to facilitate the migration to whoever might need it. At no time I tried to take the authorship of this work or to take the honors of the proposal or disrespect or honor the original author who has done so much good work.

To avoid future confusion, is there any guide to collaborate? I could not find it

@pedrobaeza
Copy link
Member

You should wait a reasonable amount of time to see if the original contributor answers (or in this case, merges the PR). If not, then you can supersede the work for not being stuck. In this case, you have made the PR in OCA at the same time you propose the other PR (and you can also propose in a code review instead of doing a full PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants