[17.0][OU-ADD] payment: migrate to 17.0

[ndd-odoo]

No description provided.

[pedrobaeza]

/ocabot migration payment

[ecino]

This record has been removed odoo/odoo@4b067a4

[ndd-odoo]

Ok nevermind won't affect the migration process

[zamberjo]

Hello, it seems that if it affects, it gives error in https://github.com/OCA/OpenUpgrade/blob/17.0/openupgrade_scripts/scripts/payment/17.0.2.0/noupdate_changes.xml#L43

... OpenUpgrade: payment: error in migration script /opt/odoo/auto/addons/openupgrade_scripts/scripts/payment/17.0.2.0/post-migration.py: while parsing /opt/odoo/auto/addons/openupgrade_scripts/scripts/payment/17.0.2.0/noupdate_changes.xml:42, somewhere inside
....
External ID not found in the system: payment.payment_method_acss_debit
...
ValueError: <class 'ValueError'>: "External ID not found in the system: payment.payment_method_acss_debit" while evaluating

[remi-filament]

Hi @duong77476-viindoo thank you for initializing these migration scripts.
I reproduce the error above, but you are right that it is not related to upgrade_analysis files but the noupdate_changes.xml need to be updated here :

OpenUpgrade/openupgrade_scripts/scripts/payment/17.0.2.0/noupdate_changes.xml

Line 43 in b2f4cfe

<field name="payment_method_ids" eval="[Command.set([ ref('payment.payment_method_ach_direct_debit'), ref('payment.payment_method_acss_debit'), ref('payment.payment_method_affirm'), ref('payment.payment_method_afterpay'), ref('payment.payment_method_alipay'), ref('payment.payment_method_bacs_direct_debit'), ref('payment.payment_method_bancontact'), ref('payment.payment_method_becs_direct_debit'), ref('payment.payment_method_boleto'), ref('payment.payment_method_card'), ref('payment.payment_method_cash_app_pay'), ref('payment.payment_method_clearpay'), ref('payment.payment_method_eps'), ref('payment.payment_method_fpx'), ref('payment.payment_method_giropay'), ref('payment.payment_method_grabpay'), ref('payment.payment_method_ideal'), ref('payment.payment_method_klarna'), ref('payment.payment_method_mobile_pay'), ref('payment.payment_method_multibanco'), ref('payment.payment_method_p24'), ref('payment.payment_method_paynow'), ref('payment.payment_method_paypal'), ref('payment.payment_method_pix'), ref('payment.payment_method_promptpay'), ref('payment.payment_method_revolut_pay'), ref('payment.payment_method_sepa_direct_debit'), ref('payment.payment_method_sofort'), ref('payment.payment_method_upi'), ref('payment.payment_method_wechat_pay'), ref('payment.payment_method_zip'), ])]"/>

to remove ref('payment.payment_method_acss_debit'), which was removed in commit listed by @ecino above, after you created the migration script (commit is from end of July 24)

[ndd-odoo]

Yes, thank you. But currently me and my company stop doing migration, we don't have enough resource and will come back when we have more employees i guess. You can create another pr from this and ping me to close