Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][OU-IMP] point_of_sale: Complete migration scripts #4417

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

pedrobaeza
Copy link
Member

@Tecnativa TT45176

@pedrobaeza pedrobaeza added this to the 16.0 milestone Apr 26, 2024
@pedrobaeza
Copy link
Member Author

FYI @carmenbianca

@pedrobaeza pedrobaeza merged commit cb0bef7 into OCA:16.0 Apr 26, 2024
2 checks passed
@pedrobaeza pedrobaeza deleted the 16.0-ou_add-point_of_sale_2nd branch April 26, 2024 18:38
Comment on lines +13 to +18
env.cr.execute("SELECT id FROM survey_survey")
for row in env.cr.fetchall():
env.cr.execute(
"UPDATE survey_survey SET access_token = %s WHERE id = %s",
(str(uuid.uuid4()), row[0]),
)
Copy link
Contributor

@legalsylvain legalsylvain Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I installed point of sale in a V15 database and a V16 database, and in each case, the request fail SELECT id FROM survey_survey;
ERREUR: la relation « survey_survey » n'existe pas
LIGNE 1 : SELECT id FROM survey_survey;

That is quite normal as survey.survey is defined in survey module that is not a dependency of point_of_sale module.

  1. Could you elaborate why you introduced that code ?
    2) I can not understand why the CI is green.

EDIT : The CI is green, because survey is marked as done, so it is installed by the CI.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, copy/paste...

Fixing it. The problem is that the module was not put on the doc (which I fixed in f52ca3f), and thus CI won't warn me, so now I'm reacting and merging all the needed pieces (as this didn't serve without pos_restaurant modules).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in dea8b8a and merging pos_sale for normalizing CI.

@carmenbianca
Copy link
Member

Thanks @pedrobaeza ! you have an amazingly good eye for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants