[16.0][OU-FIX] payment: install account_payment module #4310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
approved these changes
Feb 16, 2024
|
I'm thinking you should put a bit of background as docstring for the method. If not, then with time, we don't remember why these choices, and they can appear to be random. |
remi-filament
force-pushed
the
16.0-fix-payment
branch
from
96da61b to
2d234d6
Compare
|
Thanks Sylvain, Pedro, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to force install of account_payment in this migration script since in v16 account_payment is auto_install = ["account"]
Without this, you may end up with v16 database without account_payment installed (if it was not in v15) and you cannot access account moves.
See #4281
cc @legalsylvain, @pedrobaeza
Sylvain, if you prefer I can do that in account module instead, but since most of fields for account_payment are moved in payment migration script, it makes sense to me to have it in that one.