Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][OU-ADD] project: migration script #4289

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

remytms
Copy link
Contributor

@remytms remytms commented Jan 31, 2024

Cortesy @SonCrits

Replace #3989

Speed improvements can be done by computing some new computed fields via SQL request. But I will not do that in this PR. As it is not mandatory.

@remytms remytms marked this pull request as draft January 31, 2024 15:59
@remytms remytms changed the title Draft: [OU-ADD] project: migration script [16.0][OU-ADD] project: migration script Jan 31, 2024
@remytms remytms marked this pull request as ready for review February 7, 2024 16:07
@remytms remytms force-pushed the 16-add-project branch 2 times, most recently from c358606 to b785e86 Compare February 7, 2024 16:15
@remytms
Copy link
Contributor Author

remytms commented Feb 7, 2024

I don't remember if I should modify the file noupdate_changes.xml.

@pedrobaeza
Copy link
Member

Yes if something shouldn't be imported, but commenting the lines.

@pedrobaeza
Copy link
Member

/ocabot migration project

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete translations for noupdate=1 records.


project / project.task / is_blocked (boolean) : NEW isfunction: function, stored
project / project.task / milestone_id (many2one) : NEW relation: project.milestone, hasdefault: compute
# TODO (speed improvement): pre-migration: pre-compute value for new computed fields
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to be done?

Copy link
Contributor Author

@remytms remytms Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I'm not going to do this. I focus on getting something that works.

@remytms
Copy link
Contributor Author

remytms commented Feb 14, 2024

I will work on this tomorrow. :)

Comment on lines +20 to +23
pad_project / project.project / description_pad (char) : DEL
pad_project / project.project / use_pads (boolean) : DEL
pad_project / project.task / description_pad (char) : DEL
# TODO: Module pad_project has been removed
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedrobaeza I'm not sure what to do with this. Should I rename the table with a legacy name to ensure that data are not deleted ? Or should I just do nothing ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say "Nothing to do", as the content is dumped on save to the description fields, and the collaboration comes now from web editor itself.

@remytms remytms force-pushed the 16-add-project branch 2 times, most recently from 007f10e to c21d9f8 Compare February 19, 2024 10:41
@pedrobaeza pedrobaeza merged commit f889b69 into OCA:16.0 Mar 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants