[14.0][OU-FIX] website: fix extract_footer_copyright_company_name #4245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @StefanRijnhart, @MiquelRForgeFlow, @pedrobaeza, |
|
The same about the commit message as in #4244 |
pilarvargas-tecnativa
force-pushed
the
14.0-fix-website-copyright_company_name
branch
from
aaabff9 to
53e3661
Compare
Thanks |
|
Check about the first line of the commit message and the |
pilarvargas-tecnativa
force-pushed
the
14.0-fix-website-copyright_company_name
branch
from
53e3661 to
c52e34c
Compare
Previous code was ignoring possible customizations on the copyright information, as it took it from the master template. With this change, the information is taken from the customized template if exists, or the master otherwise, using the existing CoW mechanism for getting it in a simple way. TT44601
pilarvargas-tecnativa
force-pushed
the
14.0-fix-website-copyright_company_name
branch
from
c52e34c to
c489fec
Compare
Done! |
pedrobaeza
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the way to get the views
cc @Tecnativa TT44601
@chienandalu @pedrobaeza please review