[16.0][OU-ADD] stock: migration #3966

hoangtiendung070797 · 2023-07-01T02:04:03Z

migration to 16.0

legalsylvain · 2023-07-01T21:56:46Z

/ocabot migration stock

Depends on :

barcodes_gs1_nomenclature : TODO

huguesdk

just a fix for an error that happened when i ran the upgrade.

openupgrade_scripts/scripts/stock/16.0.1.1/pre-migration.py

openupgrade_scripts/scripts/stock/16.0.1.1/post-migration.py

jaredkipe · 2023-07-20T19:51:02Z

I don't know about the dependency, but I've run a very real database through this and there are a few problems.

stock/16.0.1.1/pre-migration.py

I believe we should have either _columns_renames or _fields_renames, both results in bad query: ALTER TABLE "stock_move_line" RENAME "product_qty" TO "reserved_qty" and psycopg2.errors.UndefinedColumn: column "product_qty" does not exist

I just commented out the inside of _columns_renames to move forward.

I get an error coming from the only line/part of the script that mentions sl.warehouse_id as psycopg2.errors.UndefinedColumn: column sl.warehouse_id does not exist

Given where I'm at in my migration, I just returned out of that function early and moved on.

Anyway, just my two cents, THANKS FOR THE MIGRATION!!!

cheese202 · 2023-08-17T07:16:05Z

Hi!
Any update with sl.warehouse_id errors and other errors above?

gdgellatly · 2023-08-31T11:47:47Z

I don't know about the dependency, but I've run a very real database through this and there are a few problems.

stock/16.0.1.1/pre-migration.py

I believe we should have either _columns_renames or _fields_renames, both results in bad query: ALTER TABLE "stock_move_line" RENAME "product_qty" TO "reserved_qty" and psycopg2.errors.UndefinedColumn: column "product_qty" does not exist

I just commented out the inside of _columns_renames to move forward.

I get an error coming from the only line/part of the script that mentions sl.warehouse_id as psycopg2.errors.UndefinedColumn: column sl.warehouse_id does not exist

Given where I'm at in my migration, I just returned out of that function early and moved on.

Anyway, just my two cents, THANKS FOR THE MIGRATION!!!

Can confirm both issues

No need for column rename after field rename is there.
stock location has no field warehouse_id.

joel-oates · 2023-09-27T12:44:50Z

openupgrade_scripts/scripts/stock/16.0.1.1/pre-migration.py

+    openupgrade.rename_tables(env.cr, _tables_renames)
+    openupgrade.rename_models(env.cr, _models_renames)
+    openupgrade.rename_fields(env, _fields_renames)
+    openupgrade.rename_columns(env.cr, _columns_renames)


This is already covered by the rename_fields as seen by the error of the column already existing

confirmed, reserved_qty is renamed by openupgrade.rename_fields(env, _fields_renames) and after by openupgrade.rename_columns(env.cr, _columns_renames)

joel-oates · 2023-09-27T12:48:15Z

openupgrade_scripts/scripts/stock/16.0.1.1/pre-migration.py

+            END as replenish_location_status
+            FROM stock_location sl
+            LEFT JOIN stock_warehouse sw
+            ON sw.id = sl.warehouse_id


The warehouse is a computed value that is new being stored, I tried adding the field using openupgrade.add_fields and calculating the value in this script, however got the following warning

add_fields: There's already an entry for warehouse_id in stock.location. This may mean that there's some misconfiguration, or simply that another module added the same field previously.

Is there a reason this cannot be moved the the post migration? allowing the module to calculate the values for us?

dansanti · 2023-10-17T22:59:50Z

I wrote a code to retrieve and update the warehouse_id based on the computation performed in Odoo 15.0. Needs reviews an work around :


_add_fields = [  
  ('warehouse_id', 'stock.location', 'stock_location', 'many2one', False, 'stock')
]

def _compute_stock_location_warehouse(env):
    openupgrade.logged_query(
        env.cr,
        """
        WITH subquery AS (
          SELECT
            UNNEST(STRING_TO_ARRAY(
              COALESCE(NULLIF(TRIM(BOTH '/' FROM parent_path), ''), '0'), '/'
            )::INTEGER[]) AS result
          FROM stock_location
        )

        UPDATE stock_location sl
        SET warehouse_id = (
          SELECT sw.id
          FROM stock_warehouse sw
          WHERE sw.view_location_id IN (SELECT result FROM subquery)
          limit 1
        )
    """)

@openupgrade.migrate()
def migrate(env, version):
    openupgrade.add_fields(env, _add_fields)
    openupgrade.rename_tables(env.cr, _tables_renames)
    openupgrade.rename_models(env.cr, _models_renames)
    openupgrade.rename_fields(env, _fields_renames)
    openupgrade.rename_columns(env.cr, _columns_renames)
    _update_stock_quant_storage_category_id(env)
    _update_stock_quant_package_pack_date(env)
    _update_sol_product_category_name(env)
    _compute_stock_location_warehouse(env)
    _compute_stock_location_replenish_location(env)

percevaq

tested in a real migration from 14 to 15 and 16.

percevaq · 2023-11-02T22:57:07Z

openupgrade_scripts/scripts/stock/16.0.1.1/pre-migration.py

+    openupgrade.rename_tables(env.cr, _tables_renames)
+    openupgrade.rename_models(env.cr, _models_renames)
+    openupgrade.rename_fields(env, _fields_renames)
+    openupgrade.rename_columns(env.cr, _columns_renames)


the order of execution of methods is not correct and gives errors

Suggested change

openupgrade.rename_tables(env.cr, _tables_renames)

openupgrade.rename_models(env.cr, _models_renames)

openupgrade.rename_fields(env, _fields_renames)

openupgrade.rename_columns(env.cr, _columns_renames)

openupgrade.rename_columns(env.cr, _columns_renames)

openupgrade.rename_fields(env, _fields_renames)

openupgrade.rename_models(env.cr, _models_renames)

openupgrade.rename_tables(env.cr, _tables_renames)

percevaq · 2023-11-02T22:59:45Z

openupgrade_scripts/scripts/stock/16.0.1.1/pre-migration.py

+                WHEN sl.usage = 'internal' AND sl.id = sw.lot_stock_id THEN True
+                ELSE FALSE


Suggested change

WHEN sl.usage = 'internal' AND sl.id = sw.lot_stock_id THEN True

ELSE FALSE

WHEN sl.usage = 'internal' AND sl.id = sw.lot_stock_id THEN TRUE

ELSE FALSE

percevaq · 2023-11-03T09:26:23Z

openupgrade_scripts/scripts/stock/16.0.1.1/pre-migration.py

+            END as replenish_location_status
+            FROM stock_location sl
+            LEFT JOIN stock_warehouse sw
+            ON sw.id = sl.warehouse_id


This left join does not work because the field does not exist and if it does exist it will be empty.

you have to change it to

Suggested change

ON sw.id = sl.warehouse_id

ON sw.lot_stock_id = sl.id

Can confirm this fix

MeeleCode · 2023-11-15T09:00:32Z

Hello! We are migrating from v13 to v16. Can you share the status of migration scripts v15 to v16? Can we help in any way to finish it?

marielejeune · 2023-11-29T14:25:21Z

Hello, do you plan to work on the previous comments or does someone plan to work on it? I also need this script for a migration. Thanks!

percevaq · 2023-11-29T17:40:55Z

I think the comment thread has not been checked. Hopefully, someone in charge of OCA will review these cases or tell us how to proceed.

percevaq · 2023-12-15T16:18:41Z

The problem is that I don't know how to proceed to upload those changes to another user's proposal.

If there is OCA documentation for this I have not found it.

There have been suggestions for changes that can be applied but I don't know if this is the right way to go about it.

Can someone from OCA point us in the right direction?

crazybolillo · 2023-12-15T19:38:55Z

diff --git a/openupgrade_scripts/scripts/stock/16.0.1.1/pre-migration.py b/openupgrade_scripts/scripts/stock/16.0.1.1/pre-migration.py
index f287c09..ff023b5 100644
--- a/openupgrade_scripts/scripts/stock/16.0.1.1/pre-migration.py
+++ b/openupgrade_scripts/scripts/stock/16.0.1.1/pre-migration.py
@@ -92,7 +92,7 @@ def _compute_stock_location_replenish_location(env):
             END as replenish_location_status
             FROM stock_location sl
             LEFT JOIN stock_warehouse sw
-            ON sw.id = sl.warehouse_id
+            ON sw.lot_stock_id = sl.id
         )
         UPDATE stock_location sl
         SET replenish_location = info.replenish_location_status
@@ -121,10 +121,10 @@ def _update_stock_quant_package_pack_date(env):
 
 @openupgrade.migrate()
 def migrate(env, version):
-    openupgrade.rename_tables(env.cr, _tables_renames)
-    openupgrade.rename_models(env.cr, _models_renames)
-    openupgrade.rename_fields(env, _fields_renames)
     openupgrade.rename_columns(env.cr, _columns_renames)
+    openupgrade.rename_fields(env, _fields_renames)
+    openupgrade.rename_models(env.cr, _models_renames)
+    openupgrade.rename_tables(env.cr, _tables_renames)
     _update_stock_quant_storage_category_id(env)
     _update_stock_quant_package_pack_date(env)
     _update_sol_product_category_name(env)

Those set of changes (which were commented on this thread) apparently fixed migration errors for me.

marielejeune · 2023-12-19T07:29:14Z

The problem is that I don't know how to proceed to upload those changes to another user's proposal.

If there is OCA documentation for this I have not found it.

There have been suggestions for changes that can be applied but I don't know if this is the right way to go about it.

Can someone from OCA point us in the right direction?

Hi,

I think the only way to do that is to open a new PR. You can cherry-pick this commit or set @hoangtiendung070797 as co-author of your commit.

tsipizic · 2024-01-15T06:56:00Z

I can confirm this PR with @crazybolillo 's patch works

percevaq · 2024-01-16T01:37:29Z

Thank you for appreciating my review and follow-up work.

More of the same.

bendem · 2024-01-24T10:48:11Z

Is there any plans to merge this, @percevaq can you open a PR with these changes cherry-picked and your fixes on top?

zamberjo · 2024-01-26T06:53:59Z

@hoangtiendung070797 can you apply the patch that @crazybolillo indicates to see if the error is solved and we can give a boost to this?

marielejeune · 2024-02-01T10:55:37Z

Hi everybody,
Since nothing evolves here, I've decided to create a new PR where I cherry-picked the commit from here, and fixed both issues you all mentioned.
Feel free to review here: #4291

andreampiovesana · 2024-02-22T07:17:15Z

@pedrobaeza we close this PR for : #4291 ?

onurugur

lgtm

hoangtiendung070797 force-pushed the v16_mig_stock branch 2 times, most recently from b90a7b5 to 65d94f3 Compare July 1, 2023 02:14

OCA-git-bot added this to the 16.0 milestone Jul 1, 2023

OCA-git-bot mentioned this pull request Jul 1, 2023

Migration to version 16.0 #3681

Open

legalsylvain added the Blocked by dependency label Jul 1, 2023

This was referenced Jul 3, 2023

[16.0][OU-ADD] stock_account: nothing to do #3971

Closed

[16.0][OU-ADD] stock_sms: nothing to do #3970

Merged

huguesdk suggested changes Jul 7, 2023

View reviewed changes

openupgrade_scripts/scripts/stock/16.0.1.1/pre-migration.py Show resolved Hide resolved

huguesdk reviewed Jul 7, 2023

View reviewed changes

openupgrade_scripts/scripts/stock/16.0.1.1/post-migration.py Outdated Show resolved Hide resolved

hoangtiendung070797 force-pushed the v16_mig_stock branch 2 times, most recently from 1744fcb to fda9382 Compare July 10, 2023 01:46

hoangtiendung070797 force-pushed the v16_mig_stock branch from fda9382 to 2707d13 Compare July 17, 2023 04:58

[OU-ADD] stock: migration

d6dfed8

hoangtiendung070797 force-pushed the v16_mig_stock branch from 2707d13 to d6dfed8 Compare July 17, 2023 06:05

legalsylvain added Dependency OK and removed Blocked by dependency labels Jul 25, 2023

carmenbianca mentioned this pull request Sep 1, 2023

[16.0][OU-ADD] stock_picking_batch: nothing to do #4115

Closed

legalsylvain mentioned this pull request Sep 1, 2023

[16.0][OU-ADD] mrp: migration #4117

Closed

joel-oates reviewed Sep 27, 2023

View reviewed changes

pedrobaeza mentioned this pull request Oct 9, 2023

[15.0 =>16.0] insert or update on table "stock_route_product" violates foreign key constraint "stock_route_product_route_id_fkey" #4154

Closed

victoralmau mentioned this pull request Oct 19, 2023

[16.0][OU-ADD] stock_dropshipping: Nothing to do #4135

Merged

1 task

legalsylvain mentioned this pull request Oct 20, 2023

[16.0][OU-ADD] product_expiry: Nothing to do #4136

Merged

1 task

percevaq reviewed Nov 3, 2023

View reviewed changes

marielejeune mentioned this pull request Feb 1, 2024

[16.0][OU-ADD] stock #4291

Merged

pedrobaeza closed this Feb 22, 2024

onurugur reviewed Mar 7, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][OU-ADD] stock: migration #3966

[16.0][OU-ADD] stock: migration #3966

hoangtiendung070797 commented Jul 1, 2023

legalsylvain commented Jul 1, 2023 •

edited

Loading

huguesdk left a comment

jaredkipe commented Jul 20, 2023

cheese202 commented Aug 17, 2023

gdgellatly commented Aug 31, 2023

joel-oates Sep 27, 2023

dansanti Oct 17, 2023

joel-oates Sep 27, 2023

dansanti commented Oct 17, 2023

percevaq left a comment

percevaq Nov 2, 2023

percevaq Nov 2, 2023

percevaq Nov 3, 2023

lijoantony Nov 11, 2023

MeeleCode commented Nov 15, 2023

marielejeune commented Nov 29, 2023

percevaq commented Nov 29, 2023

percevaq commented Dec 15, 2023

crazybolillo commented Dec 15, 2023

marielejeune commented Dec 19, 2023

tsipizic commented Jan 15, 2024 •

edited

Loading

percevaq commented Jan 16, 2024

bendem commented Jan 24, 2024

zamberjo commented Jan 26, 2024

marielejeune commented Feb 1, 2024

andreampiovesana commented Feb 22, 2024

onurugur left a comment

		WHEN sl.usage = 'internal' AND sl.id = sw.lot_stock_id THEN True
		ELSE FALSE

[16.0][OU-ADD] stock: migration #3966

[16.0][OU-ADD] stock: migration #3966

Conversation

hoangtiendung070797 commented Jul 1, 2023

legalsylvain commented Jul 1, 2023 • edited Loading

huguesdk left a comment

Choose a reason for hiding this comment

jaredkipe commented Jul 20, 2023

cheese202 commented Aug 17, 2023

gdgellatly commented Aug 31, 2023

joel-oates Sep 27, 2023

Choose a reason for hiding this comment

dansanti Oct 17, 2023

Choose a reason for hiding this comment

joel-oates Sep 27, 2023

Choose a reason for hiding this comment

dansanti commented Oct 17, 2023

percevaq left a comment

Choose a reason for hiding this comment

percevaq Nov 2, 2023

Choose a reason for hiding this comment

percevaq Nov 2, 2023

Choose a reason for hiding this comment

percevaq Nov 3, 2023

Choose a reason for hiding this comment

lijoantony Nov 11, 2023

Choose a reason for hiding this comment

MeeleCode commented Nov 15, 2023

marielejeune commented Nov 29, 2023

percevaq commented Nov 29, 2023

percevaq commented Dec 15, 2023

crazybolillo commented Dec 15, 2023

marielejeune commented Dec 19, 2023

tsipizic commented Jan 15, 2024 • edited Loading

percevaq commented Jan 16, 2024

bendem commented Jan 24, 2024

zamberjo commented Jan 26, 2024

marielejeune commented Feb 1, 2024

andreampiovesana commented Feb 22, 2024

onurugur left a comment

Choose a reason for hiding this comment

legalsylvain commented Jul 1, 2023 •

edited

Loading

tsipizic commented Jan 15, 2024 •

edited

Loading