Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][OU-ADD] product #3880

Merged
merged 1 commit into from
Jun 28, 2023
Merged

[16.0][OU-ADD] product #3880

merged 1 commit into from
Jun 28, 2023

Conversation

remytms
Copy link
Contributor

@remytms remytms commented May 18, 2023

Renamed field name -> partner_id from model product.supplierinfo

@remytms
[OU-ADD] product
fa89f27 
Renamed field name -> partner_id from model product.supplierinfo
legalsylvain
legalsylvain approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! Code review. Lgtm.

openupgrade_scripts/scripts/product/16.0.1.2/upgrade_analysis_work.txt
@@ -0,0 +1,29 @@
---Models in module 'product'---
new model product.tag
Copy link
Contributor

@legalsylvain legalsylvain May 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that odoo integrates now oca features présent in https://github.com/OCA/product-attribute/tree/14.0/product_template_tags

If yes some migrations scripts could be added in a second time. (Not in the scope of this PR)
Cc @ivantodorovich
@patrickrwilson

@remytms
Copy link
Contributor Author

remytms commented May 31, 2023

@legalsylvain Can you reference this PR with /ocabot migration product ? :)

@OCA-git-bot
Copy link
Contributor

Sorry @remytms you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@legalsylvain
Copy link
Contributor

/ocabot migration product

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone May 31, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request May 31, 2023
Open
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@legalsylvain
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-3880-by-legalsylvain-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d549cff into OCA:16.0 Jun 28, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at bb83e54. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SonCrits SonCrits SonCrits approved these changes

@legalsylvain legalsylvain legalsylvain approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@remytms @OCA-git-bot @legalsylvain @SonCrits