Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] account: migration script #3505

Merged
merged 2 commits into from
Dec 6, 2022
Merged

[15.0][MIG] account: migration script #3505

merged 2 commits into from
Dec 6, 2022

Conversation

MiquelRForgeFlow
Copy link
Contributor

Supersedes #3284.

@MiquelRForgeFlow MiquelRForgeFlow added this to the 15.0 milestone Aug 3, 2022
@MiquelRForgeFlow MiquelRForgeFlow mentioned this pull request Aug 3, 2022
Closed
@MiquelRForgeFlow
Copy link
Contributor Author

/ocabot migration account

@OCA-git-bot OCA-git-bot mentioned this pull request Aug 3, 2022
Open
@OCA-git-bot
Copy link
Contributor

The migration issue (#3287) has been updated to reference the current pull request.
however, a previous pull request was referenced : #3284.
Perhaps you should check that there is no duplicate work.
CC : @sang250399

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the v15_mig_account branch 7 times, most recently from 4e88a30 to 93a89e2 Compare August 4, 2022 10:45
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the v15_mig_account branch 6 times, most recently from 0095a95 to f3866f2 Compare September 16, 2022 11:13
@katyukha
Copy link

katyukha commented Oct 3, 2022

Hi,

Do you need any help with this pull request?

PS: As i see this pull request has tag Blocked by dependency, but there is no reference to what dependency blocks it.

@MiquelRForgeFlow
Copy link
Contributor Author

but there is no reference to what dependency blocks it.

product

florian-dacosta
florian-dacosta approved these changes Oct 10, 2022
View reviewed changes
Copy link

@florian-dacosta florian-dacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM + I ran the migration on real database and it went smoothly.
I could not do advanced tests on this migrated database though

bealdav
bealdav approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@bealdav bealdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use upgrade on local demo database. It's ok

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

StefanRijnhart
StefanRijnhart requested changes Oct 13, 2022
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posting a 'Request changes' comment to prevent ocabot to mark this PR as 'Ready for merge'.

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the v15_mig_account branch 2 times, most recently from eb36cbe to b4ff53b Compare October 20, 2022 09:12
mostafabarmshory
mostafabarmshory approved these changes Nov 9, 2022
View reviewed changes
Copy link

@mostafabarmshory mostafabarmshory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I check with my demo DB. This works.

@bealdav
Copy link
Member

bealdav commented Dec 5, 2022

Hi @StefanRijnhart , do you have time to check @MiquelRForgeFlow new commit here.
It seems he answer all your requests. Thanks a lot.

StefanRijnhart
StefanRijnhart approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bealdav for the reminder. Sorry for losing track of this one!

@StefanRijnhart StefanRijnhart merged commit 5609a9d into OCA:15.0 Dec 6, 2022
@pedrobaeza pedrobaeza deleted the v15_mig_account branch December 6, 2022 10:21
@mostafabarmshory
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza left review comments

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

@bealdav bealdav bealdav approved these changes

@florian-dacosta florian-dacosta florian-dacosta approved these changes

@mostafabarmshory mostafabarmshory mostafabarmshory approved these changes

Assignees
No one assigned
Labels
approved needs review
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
9 participants
@MiquelRForgeFlow @OCA-git-bot @katyukha @bealdav @mostafabarmshory @StefanRijnhart @florian-dacosta @pedrobaeza @sang250399