Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG][15.0] utm: migration script #3282

Merged
merged 1 commit into from
Jul 6, 2022
Merged

[MIG][15.0] utm: migration script #3282

merged 1 commit into from
Jul 6, 2022

Conversation

sang250399
Copy link

This PR

Migration done

@legalsylvain

This comment was marked as duplicate.

Sign in to view
@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jun 15, 2022
@legalsylvain
Copy link
Contributor

/ocabot migration utm

@OCA-git-bot OCA-git-bot mentioned this pull request Jun 15, 2022
Open
legalsylvain
legalsylvain approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@legalsylvain legalsylvain merged commit 639392e into OCA:15.0 Jul 6, 2022
@pedrobaeza
Copy link
Member

@legalsylvain please wait until we resolve the CI problem (tests are not being executed) for merging new PRs.

@pedrobaeza
Copy link
Member

@legalsylvain you can continue, but please check before merging if the modules are being detected correctly (check in the logs for missing dependency text)

@pedrobaeza
Copy link
Member

In fact, in this PR the test haven't been correctly executed. Check in https://github.com/OCA/OpenUpgrade/runs/6892985524?check_suite_focus=true#step:13:54 that only base test has been run.

@pedrobaeza
Copy link
Member

But on main branch tests they are: https://github.com/OCA/OpenUpgrade/runs/7210598841?check_suite_focus=true#step:13:54

I'm totally puzzled about what's happening...

@legalsylvain
Copy link
Contributor

@legalsylvain please wait until we resolve the CI problem (tests are not being executed) for merging new PRs.

sorry I've missed that point. is there a dedicated issue for that trouble ?

@pedrobaeza
Copy link
Member

Please follow the conversation on mail PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legalsylvain legalsylvain legalsylvain approved these changes

@daonamutc1 daonamutc1 daonamutc1 approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
5 participants
@sang250399 @legalsylvain @OCA-git-bot @pedrobaeza @daonamutc1