Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] account_edi_facturx: nothing to do #3046

Merged
merged 1 commit into from
Jan 7, 2022
Merged

[14.0][MIG] account_edi_facturx: nothing to do #3046

merged 1 commit into from
Jan 7, 2022

Conversation

tranngocson1996
Copy link

This PR

Nothing to do

@tranngocson1996
Copy link
Author

thank @legalsylvain

@pedrobaeza pedrobaeza added this to the 14.0 milestone Jan 6, 2022
pedrobaeza
pedrobaeza requested changes Jan 6, 2022
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the Nothing to do in the coverage file, and that way the CI also activates the check to see if everything goes OK.

@pedrobaeza
Copy link
Member

Seeing the file in

https://github.com/OCA/OpenUpgrade/blob/14.0/docsource/modules130-140.rst

in fact it should be put as Done. Renamed from account_facturx

@pedrobaeza pedrobaeza mentioned this pull request Jan 6, 2022
Open
@tranngocson1996 tranngocson1996 force-pushed the v14_mig_account_edi_facturx branch from baad1c7 to 4553dda Compare January 7, 2022 01:30
@tranngocson1996
Copy link
Author

@pedrobaeza Done sir

@pedrobaeza pedrobaeza changed the title [MIG][14.0] account_edi_facturx: nothing to do [14.0][MIG] account_edi_facturx: nothing to do Jan 7, 2022
@pedrobaeza pedrobaeza merged commit 4dae323 into OCA:14.0 Jan 7, 2022
@tranngocson1996 tranngocson1996 mentioned this pull request Jan 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@legalsylvain legalsylvain legalsylvain approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tranngocson1996 @pedrobaeza @legalsylvain @OCA-git-bot