Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][14.0] association: nothing to do #3045

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

tranngocson1996
Copy link

This PR

Nothing to do (it didn't have a migration folder)

@legalsylvain
Copy link
Contributor

Migration folder should be present.
Don't you think ? Cc @pedrobaeza, @StefanRijnhart ?
Could you try to regenerate it, with upgrade analysis ?'otherwise thanks for the work.

@tranngocson1996
Copy link
Author

Migration folder should be present. Don't you think ? Cc @pedrobaeza, @StefanRijnhart ? Could you try to regenerate it, with upgrade analysis ?'otherwise thanks for the work.

Thank @legalsylvain. I tried to regenerate it, but it didn't have a migration folder.

@pedrobaeza pedrobaeza added this to the 14.0 milestone Jan 6, 2022
@pedrobaeza
Copy link
Member

When there's no change, no migrations folder is generated AFAIK.

@tranngocson1996
Copy link
Author

When there's no change, no migrations folder is generated AFAIK.

@pedrobaeza I think that right

@legalsylvain
Copy link
Contributor

@pedrobaeza : thanks for your answer.

I don't understand the difference between :

  • association module : no analysis file created.
  • analytic module : an analysis file created that says that nothing changed. Ref.

any idea ?

@pedrobaeza
Copy link
Member

Well, you tell me that maintains the upgrade_analysis module. I think there's a decision branch that creates nothing depending on the detected things.

@pedrobaeza
Copy link
Member

I can't say, as I have never dug enough on such module.

@legalsylvain
Copy link
Contributor

I just meld association manually.
nothing changed.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-3045-by-legalsylvain-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9a4e0cc. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants