Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG][14.0] account_check_printing: Migration script #3044

Merged
merged 1 commit into from
Jan 12, 2022
Merged

[MIG][14.0] account_check_printing: Migration script #3044

merged 1 commit into from
Jan 12, 2022

Conversation

tranngocson1996
Copy link

This PR

Migration script

@tranngocson1996
Copy link
Author

@legalsylvain plz review !!!
cc: @pedrobaeza

legalsylvain
legalsylvain reviewed Jan 5, 2022
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some remarks. LGTM otherwise.

openupgrade_scripts/scripts/account_check_printing/14.0.1.0/pre-migration.py Outdated Show resolved Hide resolved
openupgrade_scripts/scripts/account_check_printing/14.0.1.0/upgrade_analysis_work.txt Show resolved Hide resolved
@tranngocson1996 tranngocson1996 force-pushed the v14_mig_account_check_printing branch from 499d29f to e07e8d9 Compare January 6, 2022 06:13
@legalsylvain
Copy link
Contributor

could you also take a look on pre-commit ?
https://github.com/OCA/OpenUpgrade/runs/4723892954?check_suite_focus=true#step:4:56

@tranngocson1996 tranngocson1996 force-pushed the v14_mig_account_check_printing branch 2 times, most recently from b599494 to d5854df Compare January 6, 2022 09:45
legalsylvain
legalsylvain requested changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the request is still failing.

could you check travis ?
thanks !

@tranngocson1996
Copy link
Author

the request is still failing.

could you check travis ? thanks !

@legalsylvain i know. I trying fix it

@tranngocson1996 tranngocson1996 force-pushed the v14_mig_account_check_printing branch 4 times, most recently from ca4e346 to 00c8b30 Compare January 10, 2022 06:39
@tranngocson1996
Copy link
Author

@legalsylvain please review this pr again. I fixed it

@tranngocson1996 tranngocson1996 force-pushed the v14_mig_account_check_printing branch from 00c8b30 to 67e01a6 Compare January 10, 2022 12:42
@tranngocson1996
Copy link
Author

@MiquelRForgeFlow done bro.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza added this to the 14.0 milestone Jan 12, 2022
@pedrobaeza pedrobaeza merged commit 33eb758 into OCA:14.0 Jan 12, 2022
@pedrobaeza pedrobaeza mentioned this pull request Jan 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@legalsylvain legalsylvain legalsylvain approved these changes

Assignees
No one assigned
Labels
approved needs review ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
5 participants
@tranngocson1996 @legalsylvain @OCA-git-bot @MiquelRForgeFlow @pedrobaeza