-
-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG][14.0] account_edi: Migration script #3040
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same remarks for the 3 others PRs.
openupgrade_scripts/scripts/account_edi/14.0.1.0/upgrade_analysis.txt
Outdated
Show resolved
Hide resolved
openupgrade_scripts/scripts/account_edi/14.0.1.0/upgrade_analysis_work.txt
Show resolved
Hide resolved
8efaae6
to
c9373d2
Compare
openupgrade_scripts/scripts/account_edi/14.0.1.0/upgrade_analysis_work.txt
Show resolved
Hide resolved
c9373d2
to
2ac33f0
Compare
@legalsylvain i fixed it. what do you think? |
@legalsylvain Have you checked it for me yet? |
2ac33f0
to
abf52b5
Compare
@pedrobaeza done bro. Check it for me again. Thank |
I'm seeing that this module is a new one, and it will be auto-installed, so no migration script will be executed, so we have to turn the approach: instead of this, you should pre-create and fill the column on |
@pedrobaeza ok i understand. I will edit it right away. |
abf52b5
to
be30008
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
@pedrobaeza thank you sir. I'm trying to migrate 13 - 14, please support me and forgive the mistakes |
@legalsylvain please check your review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks pedro ! Indeed if the module was not installed, migration script will not ve executed. Nice catch.
/ocabot merge nobump
This PR has the |
Thank @legalsylvain @pedrobaeza |
@legalsylvain remember that the ocabot command doesn't serve in the approval comment, but in OU I prefer to manually merge, as there's no advantage in triggering another build. |
@pedrobaeza : ocabot merge doesn't work with OU ? It was working before. Or I'm wrong ? |
I'm not saying that. I quote my text: |
OK. sorry I missread. |
This PR
Migration script