Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] delivery #2998

Merged
merged 2 commits into from
Jul 29, 2022
Merged

[14.0][MIG] delivery #2998

merged 2 commits into from
Jul 29, 2022

Conversation

MiquelRForgeFlow
Copy link
Contributor

Supersedes #2782.

@MiquelRForgeFlow MiquelRForgeFlow added this to the 14.0 milestone Dec 3, 2021
@MiquelRForgeFlow MiquelRForgeFlow mentioned this pull request Dec 3, 2021
Closed
@hieu1211 hieu1211 mentioned this pull request Jan 17, 2022
Merged
@MiquelRForgeFlow MiquelRForgeFlow mentioned this pull request Jun 20, 2022
Closed
legalsylvain
legalsylvain reviewed Jun 20, 2022
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure to change the policy of the product ?

Otherwise lgtm.

@pedrobaeza
Copy link
Member

Are you sure to change the policy of the product ?

In fact, it's not changed at all, as previously was using the default value which is that one. The only possible alteration is if you change the default invoicing policy and then install delivery module, so it's good to rewrite it.

@pedrobaeza pedrobaeza merged commit 3a4a9a6 into OCA:14.0 Jul 29, 2022
@pedrobaeza pedrobaeza deleted the 14.0-MIG-delivery branch July 29, 2022 17:53
@pedrobaeza pedrobaeza mentioned this pull request Jul 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legalsylvain legalsylvain legalsylvain left review comments

@pedrobaeza pedrobaeza Awaiting requested review from pedrobaeza

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@MiquelRForgeFlow @pedrobaeza @legalsylvain @Chanakya-OSI