[14.0][MIG] website_sale #2994
Merged
[14.0][MIG] website_sale #2994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiquelRForgeFlow
force-pushed
the
14.0-MIG-website_sale
branch
2 times, most recently
from
bc5a01a to
b4c944c
Compare
MiquelRForgeFlow
force-pushed
the
14.0-MIG-website_sale
branch
from
b4c944c to
06d83de
Compare
pedrobaeza
reviewed
Jun 19, 2022
openupgrade_scripts/scripts/website_sale/14.0.1.0/noupdate_changes.xml
Outdated
Show resolved
Hide resolved
| # DONE: pre-migration: set default '' in case is NULL | ||
|
|
||
| website_sale / product.ribbon / bg_color (char) : NEW | ||
| website_sale / product.ribbon / text_color (char) : NEW |
There was a problem hiding this comment.
Shouldn't this preserved the old colors? What happens if not filled?
There was a problem hiding this comment.
These are new fields, new features, for more customization. The old colors were defined by class, so they should still be in the html_class.
odoo/odoo@c058f19
openupgrade_scripts/scripts/website_sale/14.0.1.0/openupgrade_analysis_work.txt
Outdated
Show resolved
Hide resolved
MiquelRForgeFlow
force-pushed
the
14.0-MIG-website_sale
branch
from
06d83de to
b212425
Compare
pedrobaeza
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #2880.