[14.0][MIG] website_cookie_notice: merged into website #2960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
requested changes
Nov 8, 2021
MiquelRForgeFlow
force-pushed
the
14.0-mig-website_cookie_notice
branch
4 times, most recently
from
335d512 to
d972100
Compare
|
@pedrobaeza I think it's ready. |
MiquelRForgeFlow
force-pushed
the
14.0-mig-website_cookie_notice
branch
from
d972100 to
c76e7e0
Compare
pedrobaeza
reviewed
Nov 15, 2021
| openupgrade.logged_query( | ||
| env.cr, | ||
| """ | ||
| WITH keys AS ( |
There was a problem hiding this comment.
What do you mean again? here we delete all views that have as key the views of 'cookie_message' and 'cookie_message_container'
| openupgrade.logged_query( | ||
| env.cr, | ||
| """ | ||
| DELETE FROM ir_model_data imd |
There was a problem hiding this comment.
I think deleting by ORM the view, the COW system deletes the rest.
|
Continue in #2840. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapting to of OCA/website#814 (comment).