Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][website_partner][mig] add migration script. #2930

Merged
merged 1 commit into from
Oct 10, 2021

Conversation

JordiBForgeFlow
Copy link
Member

No description provided.

Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi. could you :

  • add a upgrade_analysis_work.txt, as usual ?
  • in this file, add a comment to say why it has to be done by script ? (orm should add this new field without script.)
  • mark the module as done ?

Thanks !

ref of the analysis file : https://github.com/OCA/OpenUpgrade/blob/14.0/openupgrade_scripts/scripts/website_partner/14.0.0.1/upgrade_analysis.txt
ref new field : https://github.com/odoo/odoo/blob/14.0/addons/website/models/mixins.py#L26

@JordiBForgeFlow JordiBForgeFlow force-pushed the 14.0-mig-website_partner branch from 348e4cc to 7b00cc6 Compare October 10, 2021 16:48
@JordiBForgeFlow
Copy link
Member Author

@legalsylvain I realized that in reality there's nothing to do in this module. I marked the module as done.

@JordiBForgeFlow JordiBForgeFlow merged commit b54ed42 into OCA:14.0 Oct 10, 2021
@pedrobaeza
Copy link
Member

website migration scripts are not yet merged, so this PR shouldn't be merged. Please check this the next time, @legalsylvain

@JordiBForgeFlow
Copy link
Member Author

Oops, my bad.

@pedrobaeza pedrobaeza deleted the 14.0-mig-website_partner branch October 10, 2021 18:43
@pedrobaeza
Copy link
Member

Ah, right, it was you who merged. That makes all the dependency chain to be installed in the CI and can provoke future errors. That's why we normally don't merge them until we are sure that the rest of the migrations are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants