Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][UPD] openupgrade_records: retrocompatibility with upgrade_analysis (v14) #2632

Conversation

MiquelRForgeFlow
Copy link
Contributor

If you try to run an analysis with upgrade_analysis comparing v13 and v14, happens that the noupdata computations break because they don't exist in v13.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 13.0-upd-openupgrade_records-compatibility-with-v14 branch from 8e8a0a5 to 0de0e4b Compare March 29, 2021 11:10
@pedrobaeza
Copy link
Member

Is this finally ready?

@MiquelRForgeFlow
Copy link
Contributor Author

Of course. I hope that the problem in #2631 is not related with this code. I haven't had time yet to check #2631 properly.

@pedrobaeza
Copy link
Member

Well, I prefer that you check if related before merging.

@StefanRijnhart
Copy link
Member

This is a duplicate of #2481, except that one returns XML files and this one returns paths to XML files. Could that be the reason of the corruption in #2631?

@MiquelRForgeFlow
Copy link
Contributor Author

@StefanRijnhart Sorry, I didn't see you already have a PR doing this. Stupid me. I will close then. This one returns paths because that's what upgrade_analysis module is doing now, see https://github.com/OCA/server-tools/blob/14.0/upgrade_analysis/models/upgrade_record.py#L170. I don't think that's the cause of the corruption of #2631, but I still have pending to check the cause in detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants