[13.0][UPD] openupgrade analysis #2565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
reviewed
Feb 16, 2021
|
Given that the records need to be managed in the modules that own them rather in the modules that override them, and that we also have the noupdate data xml for every module, what is it that these lines add to the analyis (in the old or the new format)? Can we perhaps just leave them out? |
|
@MiquelRForgeFlow I see what Stefan says as a good proposal. |
MiquelRForgeFlow
force-pushed
the
13.0-upd-openupgrade_analysis
branch
2 times, most recently
from
e567133 to
85415ab
Compare
|
@StefanRijnhart @pedrobaeza Done! |
MiquelRForgeFlow
force-pushed
the
13.0-upd-openupgrade_analysis
branch
3 times, most recently
from
5eab47a to
bffa5e2
Compare
|
@StefanRijnhart @pedrobaeza I have added more improvements in the analysis as you can see in the commits. The comparison of m2m columns has proved to be useful!! |
|
Very nice, thank you! |
MiquelRForgeFlow
force-pushed
the
13.0-upd-openupgrade_analysis
branch
from
bffa5e2 to
2067046
Compare
|
I suppose we need to add this to the recently migrated OCA/server-tools#1941 |
pedrobaeza
reviewed
Mar 1, 2021
Given that the records need to be managed in the modules that own them rather in the modules that override them, and that we also have the noupdate data xml for every module, then we left out the lines that where indicating the override of records.
MiquelRForgeFlow
force-pushed
the
13.0-upd-openupgrade_analysis
branch
from
db4d5f0 to
2d9eb88
Compare
pedrobaeza
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPD indicator means it's not the creation of the record, but an update of the record. So, DEL(UPD) means a deletion of that update in that module and NEW(UPD) means new update of that record in that module.
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr