Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD][14.0] Framework, analysis and base #2482

Merged
merged 6 commits into from
Jan 20, 2021
Merged

[ADD][14.0] Framework, analysis and base #2482

merged 6 commits into from
Jan 20, 2021

Conversation

StefanRijnhart
Copy link
Member

@StefanRijnhart StefanRijnhart commented Dec 15, 2020 •
edited
Loading

New design by @legalsylvain, implementation by @legalsylvain and myself based on the efforts of all the core contributors to the project over the last 8 years.

@StefanRijnhart StefanRijnhart added this to the 14.0 milestone Dec 15, 2020
@StefanRijnhart
Copy link
Member Author

I will be adding the docs in a follow-up PR.

@StefanRijnhart StefanRijnhart mentioned this pull request Dec 15, 2020
Closed
6 tasks
@StefanRijnhart

This comment has been minimized.

Sign in to view
@legalsylvain

This comment has been minimized.

Sign in to view
@StefanRijnhart

This comment has been minimized.

Sign in to view
@legalsylvain

This comment has been minimized.

Sign in to view
@StefanRijnhart

This comment has been minimized.

Sign in to view
@legalsylvain

This comment has been minimized.

Sign in to view
@StefanRijnhart

This comment has been minimized.

Sign in to view
@legalsylvain

This comment has been minimized.

Sign in to view
@StefanRijnhart

This comment has been minimized.

Sign in to view
@StefanRijnhart

This comment has been minimized.

Sign in to view
@StefanRijnhart

This comment has been minimized.

Sign in to view
@legalsylvain

This comment has been minimized.

Sign in to view
MiquelRForgeFlow
MiquelRForgeFlow reviewed Dec 17, 2020
View reviewed changes
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why your second commit says that something is moved to server-tools/14.0? but then I go to OCA/server-tools repo and I don't see anything there. Furthermore, this PR has CI green, so it seems it doesn't need anything more in any other place, right?

openupgrade_scripts/scripts/base/14.0.1.3/pre-migrate.py Show resolved Hide resolved
@legalsylvain
Copy link
Contributor

Hi @MiquelRForgeFlow. thanks for your review

Why your second commit says that something is moved to server-tools/14.0? but then I go to OCA/server-tools repo and I don't see anything there. Furthermore, this PR has CI green, so it seems it doesn't need anything more in any other place, right?

here is the PR. OCA/server-tools#1941
The upgrade_analysis module (previously named openupgrade_records) has been renamed, refactored, and made more generic and set in server-tools. This module generated the analysis files that @StefanRijnhart is proposing in the current PR.
see #2440 for the whole discussion.
kind regards.

MiquelRForgeFlow
MiquelRForgeFlow reviewed Dec 17, 2020
View reviewed changes
openupgrade_scripts/apriori.py Outdated Show resolved Hide resolved
openupgrade_scripts/apriori.py Show resolved Hide resolved
@MiquelRForgeFlow
Copy link
Contributor

@legalsylvain thanks :D

@StefanRijnhart
Copy link
Member Author

StefanRijnhart commented Dec 17, 2020 •
edited
Loading

@MiquelRForgeFlow thanks for the review. I've regenerated the analysis after your updates on the merged and renamed modules. You can inspect the result in the new commit. The changes in the analysis also reflect some unrelated changes in the gamification module in core Odoo.

I'll rebase at some point.

@StefanRijnhart StefanRijnhart force-pushed the add/14.0/framework branch 2 times, most recently from 6b29afa to b42c063 Compare December 18, 2020 06:59
@StefanRijnhart
Copy link
Member Author

Squashed the 'analysis' commits.

@MiquelRForgeFlow is it PR OK for you?

MiquelRForgeFlow
MiquelRForgeFlow approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanRijnhart
Copy link
Member Author

Thanks @MiquelRForgeFlow!

@legalsylvain your approval would be appropriate before the merge, I think.

@StefanRijnhart StefanRijnhart mentioned this pull request Jan 20, 2021
Merged
legalsylvain
legalsylvain approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure !

Let's go with this new design !

thanks.

@StefanRijnhart
Copy link
Member Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-2482-by-StefanRijnhart-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 3a3f420 into 14.0 Jan 20, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4bb92cc. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot deleted the add/14.0/framework branch January 20, 2021 10:17
@pedrobaeza pedrobaeza mentioned this pull request Jun 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@legalsylvain legalsylvain legalsylvain approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
6 participants
@StefanRijnhart @legalsylvain @MiquelRForgeFlow @OCA-git-bot @pedrobaeza @carlosdauden