Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] purchase #2310

Merged
merged 2 commits into from
May 7, 2021
Merged

[13.0][MIG] purchase #2310

merged 2 commits into from
May 7, 2021

Conversation

MiquelRForgeFlow
Copy link
Contributor

Migration of purchase.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@MiquelRForgeFlow MiquelRForgeFlow added this to the 13.0 milestone Apr 22, 2020
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 13.0-mig-purchase-scripts branch from 845a89a to 59657f1 Compare October 21, 2020 19:10
kos94ok-3D
kos94ok-3D reviewed Oct 30, 2020
View reviewed changes
Copy link

@kos94ok-3D kos94ok-3D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think need to keep a behave written in the _inverse_qty_received function
изображение

addons/purchase/migrations/13.0.1.2/post-migration.py Outdated Show resolved Hide resolved
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 13.0-mig-purchase-scripts branch from 59657f1 to 0c73ea0 Compare October 30, 2020 17:22
legalsylvain
legalsylvain reviewed Oct 30, 2020
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor remarks. Lgtm otherwise. Thanks !

addons/purchase/migrations/13.0.1.2/post-migration.py Show resolved Hide resolved
addons/purchase/migrations/13.0.1.2/post-migration.py Outdated Show resolved Hide resolved
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 13.0-mig-purchase-scripts branch from 0c73ea0 to c7c6900 Compare November 3, 2020 14:45
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza mentioned this pull request Dec 7, 2020
Closed
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 13.0-mig-purchase-scripts branch 4 times, most recently from 6d450d4 to 051a850 Compare December 9, 2020 12:42
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 13.0-mig-purchase-scripts branch 2 times, most recently from 8676dd9 to fe792a5 Compare February 11, 2021 18:53
@bishalgit
Copy link

@MiquelRForgeFlow Should I review this one? Why is this still not merged?

@abdounasser202
Copy link

I think the migration of this module blocks the one from sale_purchase

@MiquelRForgeFlow
Copy link
Contributor Author

MiquelRForgeFlow commented Feb 16, 2021 •
edited
Loading

Should I review this one?

Reviews are always welcomed.

Why is this still not merged?

Because @pedrobaeza still has not reviewed it.

@pedrobaeza
Copy link
Member

Well, this one is heavy and some experienced reviewer is a good choice for not merging something not completed. Anyway, right now the CI is red, so it must be solved before merging. I will review this meanwhile. @MiquelRForgeFlow please check.

@MiquelRForgeFlow
Copy link
Contributor Author

MiquelRForgeFlow commented Feb 16, 2021 •
edited
Loading

@pedrobaeza The error in CI is due to purchase_stock, which should not be taken into account, as it will follow this PR.

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 13.0-mig-purchase-scripts branch from fe792a5 to e56fb69 Compare February 16, 2021 11:55
@kos94ok-3D
Copy link

@MiquelRForgeFlow Runbot is red so maybe better move code from #2314 here.
@pedrobaeza Do you plan to review it until summer?

@pedrobaeza
Copy link
Member

I have a local branch with the needed changes.

@pedrobaeza pedrobaeza force-pushed the 13.0-mig-purchase-scripts branch from e56fb69 to 4329835 Compare May 7, 2021 19:49
@pedrobaeza pedrobaeza force-pushed the 13.0-mig-purchase-scripts branch from 4329835 to 180ab3d Compare May 7, 2021 23:23
pedrobaeza
pedrobaeza approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed and performed latest fine-tune

@pedrobaeza pedrobaeza merged commit 9e50c9c into OCA:13.0 May 7, 2021
@pedrobaeza pedrobaeza deleted the 13.0-mig-purchase-scripts branch May 7, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kos94ok-3D kos94ok-3D kos94ok-3D approved these changes

@ThomasBinsfeld ThomasBinsfeld ThomasBinsfeld left review comments

@legalsylvain legalsylvain legalsylvain left review comments

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@Abranes Abranes Abranes approved these changes

Assignees
No one assigned
Labels
approved needs review ready to merge
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
9 participants
@MiquelRForgeFlow @OCA-git-bot @bishalgit @abdounasser202 @pedrobaeza @kos94ok-3D @legalsylvain @Abranes @ThomasBinsfeld