[13.0][MIG] website #2299
Merged
[13.0][MIG] website #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yasaie
force-pushed
the
13.0-mig-website
branch
from
934c6c7 to
29d2409
Compare
gdgellatly
reviewed
Apr 25, 2020
Yasaie
force-pushed
the
13.0-mig-website
branch
from
29d2409 to
1699946
Compare
MiquelRForgeFlow
force-pushed
the
13.0-mig-website
branch
from
9aac32b to
1d6dcc7
Compare
MiquelRForgeFlow
approved these changes
Aug 3, 2020
kos94ok-3D
approved these changes
Nov 3, 2020
|
This PR has the |
pedrobaeza
previously requested changes
Nov 3, 2020
There was a problem hiding this comment.
This is missing some work on COW views that my colleague @yajo is doing, so this can't be merged yet.
MiquelRForgeFlow
force-pushed
the
13.0-mig-website
branch
from
1d6dcc7 to
27574dc
Compare
MiquelRForgeFlow
force-pushed
the
13.0-mig-website
branch
from
27574dc to
0b7659d
Compare
yajo
force-pushed
the
13.0-mig-website
branch
from
572cae5 to
df42149
Compare
|
I rebased to see if it fixes the build. |
|
OCA/openupgradelib#223 is merged, so I rebuilt, let's see now. |
yajo
pushed a commit
to Tecnativa/openupgradelib
that referenced
this pull request
Jan 21, 2021
Fixes https://github.com/OCA/OpenUpgrade/pull/2299/checks?check_run_id=1741234705#step:12:7045 from OCA/OpenUpgrade#2299. You cannot use `IN` to search in an `ARRAY`, which is the type of data that psycopg2 passes to postgres from a python `list`. Also, an empty `tuple` would fail too. Using `= ANY (%s)` is the safest. @Tecnativa TT23136
MiquelRForgeFlow
force-pushed
the
13.0-mig-website
branch
from
df42149 to
ee04925
Compare
|
Why last commit changes all lines if the only legit change is adding a line? |
|
This PR has the |
|
It must be something related to line endings or similar. Let me fix it. |
yajo
force-pushed
the
13.0-mig-website
branch
from
ee04925 to
fc409fb
Compare
|
It should be OK now. |
|
good 👍 |
|
could we merge then? |
pedrobaeza
requested changes
Jan 24, 2021
addons/website/migrations/13.0.1.0/openupgrade_analysis_work.txt
Outdated
Show resolved
Hide resolved
addons/website/migrations/13.0.1.0/openupgrade_analysis_work.txt
Outdated
Show resolved
Hide resolved
pedrobaeza
referenced
this pull request
in OCA/openupgradelib
Jan 28, 2021
Not doing this operation on >= v12 can lead also to let garbage XML-IDs, and what is more important, to not let Odoo to automatically remove the column when uninstalling the module.
MiquelRForgeFlow
force-pushed
the
13.0-mig-website
branch
from
fc409fb to
f0b220b
Compare
In v12, websites used the company logo. In v13, websites have their own logo. Without this patch, websites get migrated without logo. @Tecnativa TT23136
Makes use of OCA/openupgradelib#220. See description to understand what these new functions do. @Tecnativa TT23136
MiquelRForgeFlow
force-pushed
the
13.0-mig-website
branch
from
f0b220b to
80d1792
Compare
|
@pedrobaeza all your comments have been attended |
pedrobaeza
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration of
websiteI confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
@Tecnativa TT23136