Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] hr_timesheet #2291

Merged
merged 1 commit into from
Nov 26, 2020
Merged

[13.0][MIG] hr_timesheet #2291

merged 1 commit into from
Nov 26, 2020

Conversation

Yasaie
Copy link
Member

@Yasaie Yasaie commented Apr 11, 2020

Migration of hr_timesheet

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@Yasaie Yasaie changed the title [MIG] hr_timesheet [13.0][MIG] hr_timesheet Apr 11, 2020
@Yasaie Yasaie force-pushed the 13.0-mig-hr_timesheet branch 2 times, most recently from 8c8c464 to da8c77a Compare April 14, 2020 09:07
@Yasaie Yasaie force-pushed the 13.0-mig-hr_timesheet branch from 6e121ce to 3b22969 Compare August 9, 2020 07:33
@gdgellatly
Copy link

gdgellatly commented Oct 2, 2020

import odoo
from odoo.modules.db import create_categories

i = 'hr_timesheet'
info = odoo.modules.load_information_from_description_file(i)
categories = info['category'].split('/')
create_categories(env.cr, categories)

I had to run this in shell to make this module migrate propoerly afterwards

@pedrobaeza pedrobaeza force-pushed the 13.0-mig-hr_timesheet branch from 3b22969 to 141b271 Compare November 26, 2020 11:07
@pedrobaeza pedrobaeza force-pushed the 13.0-mig-hr_timesheet branch from 141b271 to 4e5c97c Compare November 26, 2020 11:08
@pedrobaeza
Copy link
Member

@gdgellatly I would say that your problem was that the initial category gathering was not done in base module or you didn't have latest code.

@pedrobaeza pedrobaeza merged commit cfbcd95 into OCA:13.0 Nov 26, 2020
@gdgellatly
Copy link

@pedrobaeza Well if that is the case I am definitely not the only one as since reporting I have had a few private mails asking for assistance in running this particular script.

@pedrobaeza
Copy link
Member

But I don't get what is the problem you are having. A crash?

@gdgellatly
Copy link

@pedrobaeza I think it might happen only in multi version migrations, because that is where it is affecting us and everyone who has asked. In my particular case it was 11 to 13.

It occurs when doing a -u all after migration and back on main odoo code. Its like a category is on no update or doesn't get created. It was 2 months ago, I don't remember too well the exact issue, and as we just do that in our end-migration script now, I never see the error again.

@pedrobaeza
Copy link
Member

OK, then I prefer to have specific steps to reproduce it and the exact error via an issue for analyzing it. Let's keep it as is for now.

@Yasaie Yasaie deleted the 13.0-mig-hr_timesheet branch July 20, 2021 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants