[13.0][MIG] utm

[MiquelRForgeFlow]

Migration scripts of utm.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[kos94ok-3D]

I think need to merge mail.mass_mailing.campaign and utm.campaign models
odoo/odoo@a661b00

[MiquelRForgeFlow]

Thanks @kos94ok-3D , it slipped my mind.

[MiquelRForgeFlow]

Yes, in v12, mail.mass_mailing.campaign has _inherits = {'utm.campaign': 'campaign_id'}

[pedrobaeza]

Then the code should be more sophisticated (I will check any way this later).

[MiquelRForgeFlow]

yeah, I am working on it

[MiquelRForgeFlow]

It's ready. @kos94ok-3D could you review again? :)

[kos94ok-3D]

Looks good. Just code review.

[AaronHForgeFlow]

utm does not depend on mass_mailing so scripts fail when mass_mailing is not installed previously 😱

[pedrobaeza]

It shouldn't. Please put the stack trace that supports your affirmation.

[AaronHForgeFlow]

This is the stack trace:

2020-08-03 13:47:19,864 7982 INFO database odoo.modules.migration: module utm: Running migration [>13.0.1.0] pre-migration 
2020-08-03 13:47:20,138 7982 INFO database OpenUpgrade: utm: pre-migration script called with version 12.0.1.0 
2020-08-03 13:47:20,459 7982 INFO database odoo.modules.registry: module utm: creating or updating database tables 
2020-08-03 13:47:20,476 7982 ERROR database odoo.sql_db: bad query: SELECT "utm_stage".id FROM "utm_stage" ORDER BY "utm_stage"."sequence"   limit 1
ERROR: relation "utm_stage" does not exist
LINE 1: SELECT "utm_stage".id FROM "utm_stage" ORDER BY "utm_stage"....

The renames for model, table and xmlid are not executed (that is correct), but then it fails when upgrading the module. It is weird because it tries to read a table before creating it. I will update this comment with my findings.

[pedrobaeza]

It shouldn't fail, as Odoo will create the table for you in most cases.

[AaronHForgeFlow]

I think the problem is Odoo defines a relation to utm_stage https://github.com/odoo/odoo/blob/13.0/addons/utm/models/utm.py#L27 before defining the model https://github.com/odoo/odoo/blob/13.0/addons/utm/models/utm.py#L51 so no issue with Openupgrade

Edited: Confirmed. It does not fail if I move that code upwards. Thank you @pedrobaeza