[MIG] website: Handle Bootstrap 3->4 and Less->Scss #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Set as WIP please, I still have to test this. |
yajo
force-pushed
the
12.0-website-bootstrap4
branch
from
22072a7 to
4024d55
Compare
yajo
force-pushed
the
12.0-website-bootstrap4
branch
2 times, most recently
from
cfaa8d7 to
bf789ae
Compare
|
Ready to review. See OCA/openupgradelib#148 (comment). |
|
@yajo Please, rebase |
pedrobaeza
requested changes
Jun 4, 2019
yajo
force-pushed
the
12.0-website-bootstrap4
branch
from
bf789ae to
84b5030
Compare
|
@mreficent @yajo I commented with @JKE-be in Spanish OCA days about the noupdate flag in several website views. They are amending this in odoo/odoo#33919, which is great, but we should modify now this code according this:
|
yajo
force-pushed
the
12.0-website-bootstrap4
branch
from
84b5030 to
6267e5a
Compare
|
All attended, except #1819 (comment), which I understand should be done separately. |
yajo
force-pushed
the
12.0-website-bootstrap4
branch
from
6267e5a to
210a0a0
Compare
|
Done now. |
In case a user has customized any Less attachments, these are disabled because 99% of the times it will fail: Syntax from Scss and Less is different, there may not be a `lessc` executable in the Odoo 12 environment, and inherited views would probably fail finding the node to replace from XPath. Automated resilient conversion between Less and Scss is close to impossible. To avoid problems, these views are disabled. You are still able to fix and reenable them manually as needed. In Odoo v12, the standard behavior when a user modifies a website template is to create a modified copy which is specific to the current website (a.k.a. COW 🐮). To benefit from this new behavior, when migrating a website from Odoo 11 to 12: 1. If a website-specific view exists, it is migrated in place. 2. Website-agnostic views are migrated in a COW 🐮 view, specific for each preexisting website. 3. Webiste-agnostic views are marked as `noupdate=0`, so when starting a new website, you have the updated views as a starting point. To make this work, all this conversion had to be made in the pre-migration stage. 4. The new copies will have a hidden migration column that indicates from which view was it copied. 5. If the views were using any default images from snippets, they will be stored in the filestore now. To make this work, OCA/openupgradelib#148 is needed.
yajo
force-pushed
the
12.0-website-bootstrap4
branch
from
210a0a0 to
4f809ff
Compare
pedrobaeza
approved these changes
Jun 15, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Less to Scss
In case a user has customized any Less attachments, these are disabled because 99% of the times it will fail: Syntax from Scss and Less is different, there may not be a
lesscexecutable in the Odoo 12 environment, and inherited views would probably fail finding the node to replace from XPath.Automated resilient conversion between Less and Scss is close to impossible.
To avoid problems, these views are disabled. You are still able to fix and reenable them manually as needed.
Bootstrap 3 to 4, with new multiwebsite support
In Odoo v12, the standard behavior when a user modifies a website template is to create a modified copy which is specific to the current website (a.k.a. COW 🐮).
To benefit from this new behavior, when migrating a website from Odoo 11 to 12:
noupdate=0, so when starting a new website, you have the updated views as a starting point. To make this work, all this conversion had to be made in the pre-migration stage.To make this work, OCA/openupgradelib#148 is needed.
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
@Tecnativa