Skip to content

Commit

Permalink
[MIG] hr_holidays (continue)
Browse files Browse the repository at this point in the history
  • Loading branch information
@MiquelRForgeFlow
MiquelRForgeFlow committed Jul 22, 2021
1 parent 141e405 commit 96f4e47
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 18 deletions.
15 changes: 7 additions & 8 deletions openupgrade_scripts/scripts/hr_holidays/14.0.1.5/pre-migration.py
View file
Original file line number Diff line number Diff line change
@@ -1,23 +1,21 @@
# Copyright (C) 2021 Open Source Integrators
# Copyright 2021 ForgeFlow S.L. <https://www.forgeflow.com>
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
from openupgradelib import openupgrade

_column_copies = {
"hr_leave_type": [("validation_type", "allocation_validation_type", "varchar")]
}

_field_renames = [
("hr.leave.type", "hr_leave_type", "validation_type", "leave_validation_type"),
]

xmlid_renames = [
(
"hr_holidays_calendar.hr_leave_report_calendar_rule_multi_company",
"hr_holidays.hr_leave_report_calendar_rule_multi_company",
),
]


@openupgrade.migrate()
def migrate(env, version):
openupgrade.copy_columns(env.cr, _column_copies)
openupgrade.rename_fields(env, _field_renames)
openupgrade.rename_xmlids(env.cr, xmlid_renames)
openupgrade.set_xml_ids_noupdate_value(
env,
"hr_holidays",
Expand All @@ -28,6 +26,7 @@ def migrate(env, version):
"hr_leave_allocation_rule_manager",
"hr_leave_allocation_rule_officer_read",
"hr_leave_allocation_rule_officer_update",
"hr_leave_report_calendar_rule_multi_company",
"hr_leave_rule_employee",
"hr_leave_rule_employee_unlink",
"hr_leave_rule_employee_update",
Expand Down
30 changes: 20 additions & 10 deletions openupgrade_scripts/scripts/hr_holidays/14.0.1.5/upgrade_analysis_work.txt
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,16 @@
---Models in module 'hr_holidays'---
---Fields in module 'hr_holidays'---
hr_holidays / hr.employee / hr_icon_display (False) : NEW selection_keys: ['presence_absent', 'presence_absent_active', 'presence_holiday_absent', 'presence_holiday_present', 'presence_present', 'presence_to_define', 'presence_undetermined'], mode: modify
hr_holidays / hr.leave / private_name (char) : NEW
hr_holidays / hr.leave.allocation / private_name (char) : NEW
# NOTHING TO DO: new features

hr_holidays / hr.leave / message_has_sms_error (boolean): module is now 'sms' ('hr_holidays')
hr_holidays / hr.leave / website_message_ids (one2many): module is now 'portal' ('hr_holidays')
hr_holidays / hr.leave.allocation / message_has_sms_error (boolean): module is now 'sms' ('hr_holidays')
hr_holidays / hr.leave.allocation / website_message_ids (one2many): module is now 'portal' ('hr_holidays')
# NOTHING TO DO: handled by ORM

hr_holidays / hr.employee / leave_manager_id (many2one) : now a function
hr_holidays / hr.leave / category_id (many2one) : now a function
hr_holidays / hr.leave / date_from (datetime) : now a function
Expand All @@ -10,37 +20,34 @@ hr_holidays / hr.leave / duration_display (char) : is now
hr_holidays / hr.leave / employee_id (many2one) : now a function
hr_holidays / hr.leave / holiday_status_id (many2one) : now a function
hr_holidays / hr.leave / manager_id (many2one) : now a function
hr_holidays / hr.leave / message_has_sms_error (boolean): module is now 'sms' ('hr_holidays')
hr_holidays / hr.leave / mode_company_id (many2one) : now a function
hr_holidays / hr.leave / name (char) : not stored anymore
hr_holidays / hr.leave / name (char) : now a function
hr_holidays / hr.leave / number_of_days (float) : now a function
hr_holidays / hr.leave / private_name (char) : NEW
hr_holidays / hr.leave / request_unit_custom (boolean) : now a function
hr_holidays / hr.leave / request_unit_half (boolean) : now a function
hr_holidays / hr.leave / request_unit_hours (boolean) : now a function
hr_holidays / hr.leave / state (selection) : now a function
hr_holidays / hr.leave / website_message_ids (one2many): module is now 'portal' ('hr_holidays')
hr_holidays / hr.leave.allocation / category_id (many2one) : now a function
hr_holidays / hr.leave.allocation / date_to (datetime) : now a function
hr_holidays / hr.leave.allocation / department_id (many2one) : now a function
hr_holidays / hr.leave.allocation / employee_id (many2one) : now a function
hr_holidays / hr.leave.allocation / holiday_status_id (many2one) : now a function
hr_holidays / hr.leave.allocation / interval_number (integer) : now a function
hr_holidays / hr.leave.allocation / interval_unit (selection) : now a function
hr_holidays / hr.leave.allocation / interval_unit (selection) : selection_keys is now '['days', 'months', 'weeks', 'years']' ('['months', 'weeks', 'years']')
hr_holidays / hr.leave.allocation / manager_id (many2one) : now a function
hr_holidays / hr.leave.allocation / message_has_sms_error (boolean): module is now 'sms' ('hr_holidays')
hr_holidays / hr.leave.allocation / mode_company_id (many2one) : now a function
hr_holidays / hr.leave.allocation / name (char) : not stored anymore
hr_holidays / hr.leave.allocation / name (char) : now a function
hr_holidays / hr.leave.allocation / number_of_days (float) : now a function
hr_holidays / hr.leave.allocation / number_per_interval (float) : now a function
hr_holidays / hr.leave.allocation / private_name (char) : NEW
hr_holidays / hr.leave.allocation / unit_per_interval (selection) : now a function
hr_holidays / hr.leave.allocation / website_message_ids (one2many): module is now 'portal' ('hr_holidays')
hr_holidays / hr.leave.type / allocation_validation_type (selection): NEW selection_keys: ['both', 'hr', 'manager'], hasdefault
# NOTHING TO DO

hr_holidays / hr.leave.allocation / interval_unit (selection) : selection_keys is now '['days', 'months', 'weeks', 'years']' ('['months', 'weeks', 'years']')
# NOTHING TO DO: added 'days' option

hr_holidays / hr.leave.type / allocation_validation_type (selection): NEW selection_keys: ['both', 'hr', 'manager'], hasdefault
hr_holidays / hr.leave.type / leave_validation_type (selection): NEW selection_keys: ['both', 'hr', 'manager', 'no_validation'], hasdefault
hr_holidays / hr.leave.type / validation_type (selection) : DEL selection_keys: ['both', 'hr', 'manager', 'no_validation']
# DONE: pre-migration: renamed field
Expand All @@ -51,9 +58,12 @@ DEL ir.actions.act_window: hr_holidays.hr_leave_action_payroll
NEW ir.actions.act_window.view: hr_holidays.action_view_activity_manager_approve
NEW ir.actions.act_window.view: hr_holidays.action_view_calendar_manager_approve
NEW ir.model.access: hr_holidays.access_hr_holidays_summary_employee
NEW ir.rule: hr_holidays.hr_leav_allocation_rule_employee_unlink (noupdate)
# NOTHING TO DO

NEW ir.model.access: hr_holidays.access_hr_leave_report_calendar [renamed from hr_holidays_calendar module]
DEL ir.model.access: hr_holidays_calendar.access_hr_leave_report_calendar [renamed to hr_holidays module]
NEW ir.rule: hr_holidays.hr_leav_allocation_rule_employee_unlink (noupdate)
# NOTHING TO DO: the prefix is corrected when merging the module

ir.rule: hr_holidays.hr_holidays_status_rule_multi_company (noupdate) (noupdate switched)
ir.rule: hr_holidays.hr_leave_allocation_rule_employee (noupdate) (noupdate switched)
Expand All @@ -75,7 +85,6 @@ ir.rule: hr_holidays.hr_leave_rule_user_read (noupdate) (noupdate switched)
ir.rule: hr_holidays.resource_leaves_base_user (noupdate) (noupdate switched)
ir.rule: hr_holidays.resource_leaves_holidays_user (noupdate) (noupdate switched)
# DONE: pre-migration: switched noupdate
# DONE: pre-migration: renamed rule xmlid

DEL ir.ui.menu: hr_holidays.hr_holidays_menu_manager_all
DEL ir.ui.menu: hr_holidays.hr_holidays_menu_manager_all_allocations
Expand All @@ -96,3 +105,4 @@ NEW ir.ui.view: hr_holidays.view_employee_tree_inherit_leave
DEL ir.ui.view: hr_holidays.hr_leave_view_form_manager_approve
DEL ir.ui.view: hr_holidays_calendar.hr_leave_report_calendar_view
DEL ir.ui.view: hr_holidays_calendar.hr_leave_report_calendar_view_form
# NOTHING TO DO

0 comments on commit 96f4e47

Please sign in to comment.