[FIX] website: fix migrate

openupgrade_scripts/scripts/website/16.0.1.0/pre-migration.py

@@ -4,23 +4,26 @@
     (
         "website.group_website_publisher",
         "website.group_website_restricted_editor",
-    )
+    ),
+    (
+        "website_sale.menu_reporting",
+        "website.menu_reporting",
+    ),
 ]
 
 # delete xml xpath for odoo add it again
 _xmlids_delete = [
-    "website.s_image_gallery_options",
-    "website.s_product_catalog_options",
-    "website.s_table_of_content_options",
-    "website.s_media_list_options",
-    "website.s_timeline_options",
     "website.website_configurator",
+    "website.website_menu",
 ]
 
 
-def _set_xml_ids_noupdate_value(env):
-    openupgrade.set_xml_ids_noupdate_value(
-        env, "website", ["action_website", "s_masonry_block_default_image_2"], False
+def delete_constraint_website_visitor_partner_uniq(env):
+    openupgrade.delete_sql_constraint_safely(
+        env,
+        "website",
+        "website_visitor",
+        "partner_uniq",
     )
 
 
@@ -52,10 +55,26 @@ def _fill_language_ids_if_null(env):
     )
 
 
+def keep_the_first_domain_when_duplicate(env):
+    openupgrade.logged_query(
+        env.cr,
+        """
+        UPDATE website
+        SET domain = NULL
+        WHERE id NOT IN (
+        SELECT MIN(id)
+        FROM website
+        GROUP BY domain
+        );
+        """,
+    )
+
+
 @openupgrade.migrate()
 def migrate(env, version):
-    _set_xml_ids_noupdate_value(env)
     _fill_partner_id_if_null(env)
     _fill_language_ids_if_null(env)
     openupgrade.rename_xmlids(env.cr, _xmlids_renames)
     openupgrade.delete_records_safely_by_xml_id(env, _xmlids_delete)
+    delete_constraint_website_visitor_partner_uniq(env)
+    keep_the_first_domain_when_duplicate(env)

openupgrade_scripts/scripts/website/16.0.1.0/upgrade_analysis_work.txt

@@ -8,13 +8,21 @@ website      / theme.website.page       / header_color (char)           : NEW
 website      / theme.website.page       / header_overlay (boolean)      : NEW
 website      / theme.website.page       / header_visible (boolean)      : NEW hasdefault: default
 website      / theme.website.page       / is_published (boolean)        : NEW
+
+# NOTHING TO DO
+
 website      / website                  / country_group_ids (many2many) : DEL relation: res.country.group
 website      / website                  / google_management_client_id (char): DEL
 website      / website                  / google_management_client_secret (char): DEL
 website      / website                  / homepage_id (many2one)        : DEL relation: website.page
 website      / website                  / homepage_url (char)           : NEW
+
+# NOTHING TO DO
+
 website      / website                  / language_ids (many2many)      : now required
-# Fill language_ids if null
+
+# DONE: Fill language_ids if null
+
 website      / website                  / plausible_shared_key (char)   : NEW
 website      / website                  / plausible_site (char)         : NEW
 website      / website.menu             / group_ids (many2many)         : DEL relation: res.groups
@@ -24,8 +32,13 @@ website      / website.visitor          / _order                        : _order
 website      / website.visitor          / active (boolean)              : DEL
 website      / website.visitor          / name (char)                   : not stored anymore
 website      / website.visitor          / name (char)                   : now related
+
+# NOTHING TO DO
+
 website      / website.visitor          / partner_id (many2one)         : now a function
-# Fill partner id if null
+
+# DONE: Fill partner id if null
+
 ---XML records in module 'website'---
 DEL ir.actions.act_url: website.start_configurator_act_url
 NEW ir.actions.client: website.action_open_website_configurator
@@ -44,17 +57,35 @@ NEW ir.asset: website.s_social_media_000_scss
 NEW ir.asset: website.s_website_form_xml
 NEW ir.model.access: website.access_website_ir_ui_view_restricted_editor
 DEL ir.model.access: website.access_website_ir_ui_view_publisher
+
+# NOTHING TO DO
+
 NEW ir.model.constraint: website.constraint_website_domain_unique
+
+# DONE: Having duplicate domains will keep the first one in pre-migration
+
 DEL ir.model.constraint: website.constraint_website_visitor_partner_uniq
+
+# DONE: safely delete pre-migration
+
 DEL ir.rule: website.website_menu (noupdate)
+
+# DONE: safely delete in pre-migration
+
 NEW ir.ui.menu: website.custom_menu_edit_menu
 NEW ir.ui.menu: website.menu_ace_editor
 NEW ir.ui.menu: website.menu_content
 NEW ir.ui.menu: website.menu_current_page
 NEW ir.ui.menu: website.menu_edit_menu
 NEW ir.ui.menu: website.menu_optimize_seo
 NEW ir.ui.menu: website.menu_page_properties
+
+# NOTHING TO DO
+
 NEW ir.ui.menu: website.menu_reporting [renamed from website_sale module]
+
+# DONE: rename in pre-migration
+
 NEW ir.ui.menu: website.menu_site
 NEW ir.ui.menu: website.menu_website_analytics
 NEW ir.ui.menu: website.menu_website_preview
@@ -80,6 +111,10 @@ DEL ir.ui.view: website.snippet_options_header_brand
 DEL ir.ui.view: website.user_navbar
 DEL ir.ui.view: website.website_configurator
 DEL ir.ui.view: website.website_publisher
+
+# NOTHING TO DO
+
 NEW res.groups: website.group_website_restricted_editor
 DEL res.groups: website.group_website_publisher
-# Rename Group
+
+# DONE: rename group in pre-migration