Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate validation of JSON Schemas (and examples) in build process #1739

Closed
MikeRalphson opened this issue Nov 1, 2018 · 7 comments · Fixed by #3784
Closed

Reinstate validation of JSON Schemas (and examples) in build process #1739

MikeRalphson opened this issue Nov 1, 2018 · 7 comments · Fixed by #3784
Assignees

Comments

@MikeRalphson
Copy link
Member

MikeRalphson commented Nov 1, 2018

This issue is a place-holder to ensure this action isn't forgotten.

If we want to validate OAS instances beyond compliance with our JSON schemas, we would need to make a choice on which validator(s) to use - this would not be an endorsement.

Can occur after the resolution of #1270 / #1236

@MikeRalphson MikeRalphson self-assigned this Nov 1, 2018
@MikeRalphson
Copy link
Member Author

MikeRalphson commented Nov 21, 2018

Script to validate JSON Schema instances against JSON Schema metaschema has been written and tested. Will be included in PR for HTML spec / registry go live.

@MikeRalphson
Copy link
Member Author

MikeRalphson commented Nov 21, 2018

Also script to validate examples against OAS schema instances, ditto.

MikeRalphson added a commit to MikeRalphson/OpenAPI-Specification that referenced this issue Apr 30, 2019
MikeRalphson added a commit to MikeRalphson/OpenAPI-Specification that referenced this issue Apr 30, 2019
@MikeRalphson
Copy link
Member Author

Bump. Should this be reworked into a GitHub action?

MikeRalphson added a commit to MikeRalphson/OpenAPI-Specification that referenced this issue Feb 15, 2020
MikeRalphson added a commit to MikeRalphson/OpenAPI-Specification that referenced this issue Feb 16, 2020
MikeRalphson added a commit to MikeRalphson/OpenAPI-Specification that referenced this issue Apr 7, 2020
MikeRalphson added a commit to MikeRalphson/OpenAPI-Specification that referenced this issue Apr 9, 2020
@Bellangelo
Copy link
Member

@MikeRalphson I can make the script to run in a Github action.

@handrews
Copy link
Member

@Bellangelo we do have this github workflow which might actually do at least some of what is needed? I think the first step is to see what we are and aren't doing, as some work on GitHub automation might not have updated this issue. If you can take a look at that, a PR adding anything we're still missing would be most welcome.

@handrews
Copy link
Member

@Bellangelo btw if you are looking for other automation/build-ish ways to contribute, you might want to check out our Automation & Infrastructure Project.

@Bellangelo
Copy link
Member

Hi @handrews, sorry for the late reply but things got busy. You are indeed correct that some thing are now covered. I have opened a PR with a detailed explanation of what is missing and what it isn't.

btw if you are looking for other automation/build-ish ways to contribute, you might want to check out our Automation & Infrastructure Project.

Thank you. This is also where I found this issue originally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
4 participants
@MikeRalphson @handrews @Bellangelo and others