Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SSL_VERIFY flag #63

Merged
merged 4 commits into from
Apr 27, 2024
Merged

Added SSL_VERIFY flag #63

merged 4 commits into from
Apr 27, 2024

Conversation

mukthy
Copy link
Contributor

@mukthy mukthy commented Sep 1, 2023

Added SSL_VERIFY flag as with some of the proxy providers it throws SSL errors like below:

(Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1129)')))

This flag will take "True" or "False" or path-to-ca.crt file.

It also helps in not installing and configuring the Proxy CA cert for each proxy provider every time in case of planning to use a proxy provider temporarily.

Added SSL_VERIFY flag as with some of the proxy providers it throws SSL errors like below:

(Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1129)')))

This flag will take "True" or "False" or path-to-ca.crt file.

It helps with not installing and configuring the Proxy CA cert.
@Nv7-GitHub
Copy link
Owner

Can you add an example to the README?

@mukthy
Copy link
Contributor Author

mukthy commented Oct 11, 2023

@Nv7-GitHub I have added an example in README. Please check: #67

@nicolaswehmeyer
Copy link

Would be great if that can be added to the library! I ran into the same issue and needed to fix it locally until I found it here. @Nv7-GitHub can you merge that change in?

@Nv7-GitHub
Copy link
Owner

I'll take a look at it in April!

@nicolaswehmeyer
Copy link

I'll take a look at it in April!

Thanks @Nv7-GitHub - that’s highly appreciated!!

Copy link
Owner

@Nv7-GitHub Nv7-GitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@Nv7-GitHub Nv7-GitHub merged commit e27f481 into Nv7-GitHub:master Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants