Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use urllib to encode string for url. #53

Merged
merged 1 commit into from
May 4, 2023

Conversation

codemee
Copy link
Contributor

@codemee codemee commented May 2, 2023

The original implementation only encode "+" for url. This make the query with addtional parameters like 'site:http://www.flag.com.tw' not working correctly.

The original implementation only encode "+" for url. This make the query with addtional parameters like 'site:http://www.flag.com.tw' not working correctly.
@codemee codemee mentioned this pull request May 2, 2023
Copy link
Owner

@Nv7-GitHub Nv7-GitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good! I was thinking about this problem when looking over this code but I wasn't sure what function to use in Python to escape URLs

@Nv7-GitHub Nv7-GitHub merged commit ebaa856 into Nv7-GitHub:master May 4, 2023
@tranhoangnguyen03
Copy link

How do I do site exclusion now? Adding " -site:website_name" no longer works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants