Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#34 Update logic for no result #50

Merged
merged 2 commits into from
Apr 27, 2023
Merged

#34 Update logic for no result #50

merged 2 commits into from
Apr 27, 2023

Conversation

InscribeDeeper
Copy link
Contributor

To avoid an infinite loop if there is no result on the first time search

@InscribeDeeper InscribeDeeper changed the title Update logic for no result Update logic for no result #34 Apr 21, 2023
@InscribeDeeper InscribeDeeper changed the title Update logic for no result #34 #34 Update logic for no result Apr 21, 2023
Nv7-GitHub
Nv7-GitHub requested changes Apr 25, 2023
View reviewed changes
Copy link
Owner

@Nv7-GitHub Nv7-GitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

googlesearch/__init__.py Outdated Show resolved Hide resolved
Nv7-GitHub
Nv7-GitHub approved these changes Apr 26, 2023
View reviewed changes
Copy link
Owner

@Nv7-GitHub Nv7-GitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good! This doesn't get affected by yield, right?

@InscribeDeeper
Copy link
Contributor Author

Seems good! This doesn't get affected by yield, right?

Yeah. If it goes to yield, the start index will definitely be larger than 0. I tested with this query: search("site:https://www.rockwellautomation.com+rockwell")

@Nv7-GitHub
Copy link
Owner

Ok, I'll include this in the next release!

@Nv7-GitHub Nv7-GitHub merged commit 2545c83 into Nv7-GitHub:master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nv7-GitHub Nv7-GitHub Nv7-GitHub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@InscribeDeeper @Nv7-GitHub