Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progress bar #29

Closed
wants to merge 2 commits into from
Closed

Add progress bar #29

wants to merge 2 commits into from

Conversation

rajat19
Copy link
Member

@rajat19 rajat19 commented Oct 5, 2019

  • Changed indentation (changed indentation to 4 spaces)
  • Added progress bar
    It will show progress based on total submissions that are finalised to be printed

@rajatgoyal715
Copy link
Member

@rajat19 I am getting this error. Can you please resolve this, or tell if I am executing the script wrongly.

Screenshot from 2019-10-06 16-57-02
Screenshot from 2019-10-06 16-58-40

@rajat19
Copy link
Member Author

rajat19 commented Oct 6, 2019

please try running it through an IDE
This import error is due to python unable to find file
In some places relative path is required
In other absolute

I would fix this so that terminal can be used

@rajat19
Copy link
Member Author

rajat19 commented Oct 6, 2019

Now run following

python setup.py install
python hsc/crawler.py

It would work now

@rajatgoyal715
Copy link
Member

After pulling your latest changes, I tried the above-mentioned commands, but still facing the same error.
Screenshot from 2019-10-06 19-36-02

@rajatgoyal715
Copy link
Member

@rajat19 Can we close this PR as per #27 (comment) ?

entry_points={
'console_scripts': [
'hsc=hsc.crawler:main',
],
}
}, install_requires=['requests']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also add getpass in this list.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok sure

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think getpass is by default installed

@rajat19
Copy link
Member Author

rajat19 commented Oct 6, 2019

Yes we can close this
I would open another PR with progress package

@rajat19 rajat19 closed this Oct 6, 2019
@rajatgoyal715 rajatgoyal715 deleted the progress-bar branch October 6, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants