Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix login success check #25

Merged
merged 2 commits into from
Aug 7, 2019
Merged

Fix login success check #25

merged 2 commits into from
Aug 7, 2019

Conversation

rajatgoyal715
Copy link
Member

Fix login success check by checking the total number of submissions.

Closes #20

Changelog

  • Removed url check
  • Get the total number of submissions
  • Check if the number is greater than zero.

Caveats

  • Won't work if the user doesn't have any submission (Success or Failure both)

@rajatgoyal715 rajatgoyal715 added the bug Something isn't working label Aug 4, 2019
@rajatgoyal715 rajatgoyal715 self-assigned this Aug 4, 2019
@rishabhsingh971 rishabhsingh971 merged commit 1a7225d into master Aug 7, 2019
@rishabhsingh971 rishabhsingh971 deleted the fixLoginIssue branch August 7, 2019 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabhsingh971 rishabhsingh971 rishabhsingh971 approved these changes

Assignees

@rajatgoyal715 rajatgoyal715

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong login success check
2 participants
@rajatgoyal715 @rishabhsingh971