Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ember-async-data a dependency #829

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

NullVoxPopuli
Copy link
Owner

@NullVoxPopuli NullVoxPopuli commented Mar 16, 2023

This is an important change because consumers of ember-resources' trackedFunction have no need to interact with ember-async-data, and the dependency can be entirely hidden.

This is blocked on the next embroider release, however (so that C.I. can go green)

@changeset-bot
Copy link

changeset-bot bot commented Mar 16, 2023

🦋 Changeset detected

Latest commit: 51dd612

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ember-resources Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2023

Estimated impact to a consuming app, depending on which bundle is imported

js min min + gzip min + brotli
/index.js 20.02 kB 3.37 kB 1.36 kB 1.2 kB
├── core/class-based/index.js 8.38 kB 1.88 kB 929 B 798 B
├── core/function-based/index.js 8.18 kB 594 B 273 B 219 B
└── core/use.js 2.91 kB 415 B 256 B 203 B
/link.js 2.67 kB 380 B 234 B 186 B
/service.js 12.94 kB 2.13 kB 1 kB 862 B
/util/cell.js 2.46 kB 917 B 434 B 366 B
/util/debounce.js 2.71 kB 837 B 430 B 352 B
/util/ember-concurrency.js 4.75 kB 1.59 kB 754 B 644 B
/util/fps.js 2.47 kB 904 B 469 B 375 B
/util/function.js 7.66 kB 2.72 kB 996 B 855 B
/util/helper.js 1.79 kB 303 B 218 B 177 B
/util/keep-latest.js 1.75 kB 512 B 296 B 235 B
/util/map.js 5.67 kB 2.5 kB 1.11 kB 939 B
/util/remote-data.js 7.33 kB 2.38 kB 798 B 697 B

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2023

@NullVoxPopuli NullVoxPopuli force-pushed the ember-async-data-as-dependency branch 2 times, most recently from 199d549 to 74dd73d Compare April 4, 2023 16:35
@NullVoxPopuli NullVoxPopuli merged commit 6a704b5 into main Apr 26, 2023
@NullVoxPopuli NullVoxPopuli deleted the ember-async-data-as-dependency branch April 26, 2023 04:15
@github-actions github-actions bot mentioned this pull request Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant