Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: cleanup not called when using factory/blueprint utility #742

Merged

Conversation

NullVoxPopuli
Copy link
Owner

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2023

🦋 Changeset detected

Latest commit: dd7234a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ember-resources Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2023

Estimated impact to a consuming app, depending on which bundle is imported

js min min + gzip min + brotli
/index.js 18.9 kB 3.35 kB 1.36 kB 1.19 kB
├── core/class-based/index.js 8.38 kB 1.88 kB 929 B 798 B
├── core/function-based/index.js 6.9 kB 576 B 269 B 215 B
└── core/use.js 2.91 kB 415 B 256 B 203 B
/util/cell.js 2.28 kB 917 B 434 B 366 B
/util/debounce.js 2.64 kB 771 B 407 B 339 B
/util/ember-concurrency.js 4.33 kB 1.53 kB 733 B 626 B
/util/function-resource.js 245 B 181 B 131 B 94 B
/util/function.js 4.85 kB 3.02 kB 1.06 kB 911 B
/util/helper.js 1.79 kB 303 B 218 B 177 B
/util/keep-latest.js 1.75 kB 512 B 296 B 235 B
/util/map.js 5.19 kB 2.13 kB 918 B 794 B
/util/remote-data.js 4.86 kB 1.75 kB 675 B 596 B

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2023

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review January 21, 2023 22:01
@NullVoxPopuli NullVoxPopuli merged commit 49c8dbc into main Jan 21, 2023
@github-actions github-actions bot mentioned this pull request Jan 21, 2023
@NullVoxPopuli NullVoxPopuli deleted the bug-cleanup-does-not-occur-when-used-in-wrapping-factory branch January 27, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant