fix(RemoteData, function-resource): wrapped template usage #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
force-pushed
the
remote-data-in-templates
branch
from
38bc686
to
3df77b4
Compare
Deploying with
|
| Latest commit: |
aa806e3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e42849df.ember-resources.pages.dev |
|
Estimated impact to a consuming app, depending on which bundle is imported
|
NullVoxPopuli
force-pushed
the
remote-data-in-templates
branch
4 times, most recently
from
9893ba7
to
d987136
Compare
In order to use RemoteData as template-resource, we need _another helper manager_, and we need to register it as well. This ends up resulting in _nested_ helper-manager invocation for a single helper-invocation call.
NullVoxPopuli
force-pushed
the
remote-data-in-templates
branch
from
d987136
to
3975e65
Compare
NullVoxPopuli
force-pushed
the
remote-data-in-templates
branch
from
9395d84
to
aa806e3
Compare
|
🎉 This PR is included in version 4.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use RemoteData as template-resource, we need
another helper manager, and we need to register it as well.
This ends up resulting in nested helper-manager invocation for a
single helper-invocation call.
Resolves: #486
Todo
RemoteDatafor use in templatesresourcefor use in templatesresourcein templates