refactor(function-runner): Refactored some Promise lines #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
after this is merged: #384 |
It seems that we didn't have to call `Promise.resolve` twice, and we also could just resolve the value in either case of being a plain value or a promise.
JimSchofield
force-pushed
the
refactor/function-runner-promise-resolution
branch
from
ba72f76
to
462aca6
Compare
|
Much thanks!!! I love when code can be deleted!!!!!! |
|
🎉 This PR is included in version 4.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that we didn't have to call
Promise.resolvetwice, and wealso could just resolve the value in either case of being a plain value
or a promise.
Seems to work locally with tests, but I will be depending on ci testing