Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect value returned when last task was dropped #835

Closed
rpemberton opened this issue Mar 20, 2023 · 1 comment · Fixed by #839 or #864 · May be fixed by MichalBryxi/ember-resources#1
Closed

Incorrect value returned when last task was dropped #835

rpemberton opened this issue Mar 20, 2023 · 1 comment · Fixed by #839 or #864 · May be fixed by MichalBryxi/ember-resources#1

Comments

@rpemberton
Copy link
Contributor

The value from the dropped task (null) is being returned instead of returning the value from the last non dropped task.

I expect this affects not only dropped tasks but cancelled tasks in general.

PR where bug was introduced: #808
Conversation: #808 (comment)

PR incoming.
@rpemberton rpemberton changed the title Incorrect value returned when last task was droppped Incorrect value returned when last task was dropped Mar 20, 2023
rpemberton added a commit to rpemberton/ember-resources that referenced this issue Mar 20, 2023
@rpemberton
fix: NullVoxPopuli#835 getting value from cancelled/dropped task
48cba3b 
Ensure that cancelled tasks are ignored
rpemberton added a commit to rpemberton/ember-resources that referenced this issue Mar 20, 2023
@rpemberton
fix: NullVoxPopuli#835 incorrect value returned when last task was dr…
6bdcc8b 
…opped

Ensure that cancelled tasks are ignored
@rpemberton rpemberton mentioned this issue Mar 20, 2023
Merged
rpemberton added a commit to rpemberton/ember-resources that referenced this issue Mar 20, 2023
@rpemberton
fix: NullVoxPopuli#835 incorrect value returned when last task was dr…
e4d9336 
…opped

Ensure that cancelled tasks are ignored
rpemberton added a commit to rpemberton/ember-resources that referenced this issue Mar 20, 2023
@rpemberton
fix: NullVoxPopuli#835 incorrect value returned when last task was dr…
ed6828c 
…opped

Ensure that cancelled tasks are ignored
@github-actions github-actions bot mentioned this issue Mar 20, 2023
Merged
NullVoxPopuli added a commit that referenced this issue Mar 20, 2023
@NullVoxPopuli @rpemberton
fix: #835 incorrect value returned when last task was dropped
acbf03d 
Co-Authored-By: rpemberton <[email protected]>
@NullVoxPopuli
Copy link
Owner

Released in 5.6.4: https://github.com/NullVoxPopuli/ember-resources/releases/tag/ember-resources%405.6.4

NullVoxPopuli added a commit that referenced this issue Mar 20, 2023
@NullVoxPopuli
Merge pull request #838 from NullVoxPopuli/bring-in-trackedTask-fix
0fd5d8e 
fix: #835 incorrect value returned when last task was dropped
@github-actions github-actions bot mentioned this issue Mar 20, 2023
Merged
@github-actions github-actions bot mentioned this issue Apr 24, 2023
Merged
@github-actions github-actions bot mentioned this issue Jun 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@NullVoxPopuli @rpemberton