umbraco#4011 - Not using a unnecessary function call in views

Nuklon · Apr 2, 2019 · 76e2f2f · 76e2f2f
1 parent d58106d
commit 76e2f2f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/grid/editors/embed.controller.js b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/grid/editors/embed.controller.js
@@ -17,9 +17,6 @@ angular.module("umbraco")
 
             $scope.embedHtml = getEmbed();
         }, false);
-    	$scope.hasEmbed = function() {
-            return $scope.control.value !== null;
-        }
     	$scope.setEmbed = function() {
             var embed = {
                 submit: function(model) {

diff --git a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/grid/editors/embed.html b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/grid/editors/embed.html
@@ -1,6 +1,6 @@
 <div ng-controller="Umbraco.PropertyEditors.Grid.EmbedController">
 
-	<div class="umb-editor-placeholder" ng-click="setEmbed()" ng-if="hasEmbed() === false">
+	<div class="umb-editor-placeholder" ng-click="setEmbed()" ng-if="control.value === null">
 		<i class="icon icon-movie-alt"></i>
 		<div class="help-text"><localize key="grid_clickToEmbed">Click to embed</localize></div>
 	</div>